RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 12:38:12 +00:00
Code Issues Activity Actions

LibWeb: Avoid String<->ByteString src conversion in HTMLImageElement

Browse source 
We already have the src attribute stored as a String, so it's completely
wasteful to convert it to a ByteString. We were even doing it twice when
loading each image.
This commit is contained in:
Andreas Kling 2023-12-29 18:25:04 +01:00
parent a19d8a4a37
commit 7e2d9bfd53
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibWeb/HTML/HTMLImageElement.cpp
View file

@ -353,8 +353,9 @@ ErrorOr<void> HTMLImageElement::update_the_image_data(bool restart_animations, b
// and it has a src attribute specified whose value is not the empty string, // and it has a src attribute specified whose value is not the empty string,
// then set selected source to the value of the element's src attribute // then set selected source to the value of the element's src attribute
// and set selected pixel density to 1.0. // and set selected pixel density to 1.0.
if (!uses_srcset_or_picture() && has_attribute(HTML::AttributeNames::src) && !deprecated_attribute(HTML::AttributeNames::src).is_empty()) { auto maybe_src_attribute = attribute(HTML::AttributeNames::src);
selected_source = TRY(String::from_byte_string(deprecated_attribute(HTML::AttributeNames::src))); if (!uses_srcset_or_picture() && maybe_src_attribute.has_value() && !maybe_src_attribute.value().is_empty()) {
selected_source = maybe_src_attribute.release_value();
selected_pixel_density = 1.0f; selected_pixel_density = 1.0f;
} }