RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 15:47:44 +00:00
Code Issues Activity Actions

Terminal: Remove redundant scroll length settings option

Browse source 
This is no longer needed as a global one is now available
under mouse settings.
This commit is contained in:
Idan Horowitz 2020-12-29 23:48:07 +02:00 • committed by Andreas Kling
parent fd945c8007
commit 7e457b98c3
4 changed files with 0 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Applications/Terminal/main.cpp
View file

@ -233,18 +233,6 @@ static RefPtr<GUI::Window> create_settings_window(TerminalWidget& terminal)
slider.set_range(0, 255); slider.set_range(0, 255);
slider.set_value(terminal.opacity()); slider.set_value(terminal.opacity());
auto& spinbox_container = settings.add<GUI::GroupBox>("Scroll length");
spinbox_container.set_layout<GUI::VerticalBoxLayout>();
spinbox_container.layout()->set_margins({ 6, 16, 6, 6 });
spinbox_container.set_fixed_height(46);
auto& spinbox = spinbox_container.add<GUI::SpinBox>();
spinbox.set_min(1);
spinbox.set_value(terminal.scroll_length());
spinbox.on_change = [&terminal](int value) {
terminal.set_scroll_length(value);
};
auto& history_size_spinbox_container = settings.add<GUI::GroupBox>("Maximum scrollback history lines"); auto& history_size_spinbox_container = settings.add<GUI::GroupBox>("Maximum scrollback history lines");
history_size_spinbox_container.set_layout<GUI::VerticalBoxLayout>(); history_size_spinbox_container.set_layout<GUI::VerticalBoxLayout>();
history_size_spinbox_container.layout()->set_margins({ 6, 16, 6, 6 }); history_size_spinbox_container.layout()->set_margins({ 6, 16, 6, 6 });

1
Base/home/anon/.config/Terminal.ini
View file

@ -3,4 +3,3 @@ Command=
[Window] [Window]
Opacity=255 Opacity=255
Bell=Visible Bell=Visible
ScrollLength=4

6
Libraries/LibVT/TerminalWidget.cpp
View file

@ -112,7 +112,6 @@ TerminalWidget::TerminalWidget(int ptm_fd, bool automatic_size_policy, RefPtr<Co
m_scrollbar->on_change = [this](int) { m_scrollbar->on_change = [this](int) {
force_repaint(); force_repaint();
}; };
set_scroll_length(m_config->read_num_entry("Window", "ScrollLength", 4));
dbgln("Load config file from {}", m_config->file_name()); dbgln("Load config file from {}", m_config->file_name());
m_cursor_blink_timer->set_interval(m_config->read_num_entry("Text", m_cursor_blink_timer->set_interval(m_config->read_num_entry("Text",
@ -843,11 +842,6 @@ int TerminalWidget::scroll_length() const
return m_scrollbar->step(); return m_scrollbar->step();
} }
void TerminalWidget::set_scroll_length(int length)
{
m_scrollbar->set_step(length);
}
String TerminalWidget::selected_text() const String TerminalWidget::selected_text() const
{ {
StringBuilder builder; StringBuilder builder;

1
Libraries/LibVT/TerminalWidget.h
View file

@ -89,7 +89,6 @@ public:
bool is_scrollable() const; bool is_scrollable() const;
int scroll_length() const; int scroll_length() const;
void set_scroll_length(int);
size_t max_history_size() const { return m_terminal.max_history_size(); } size_t max_history_size() const { return m_terminal.max_history_size(); }
void set_max_history_size(size_t value) { m_terminal.set_max_history_size(value); } void set_max_history_size(size_t value) { m_terminal.set_max_history_size(value); }