mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 04:27:43 +00:00
AK+Everywhere: Disallow Error::from_string_view(FooString)
That pattern seems to show up a lot in code written by people that aren't intimately familiar with the lifetime model of Error and Strings. This commit makes the compiler detect it and present a more helpful diagnostic than "garbage string at runtime".
This commit is contained in:
parent
cc35bab143
commit
7e6341587b
7 changed files with 29 additions and 14 deletions
|
@ -1801,7 +1801,7 @@ ErrorOr<NonnullRefPtr<GUI::Action>> HackStudioWidget::create_open_project_config
|
|||
|
||||
if (FileSystem::exists(parent_directory) && !FileSystem::is_directory(parent_directory)) {
|
||||
formatted_error_string_holder = DeprecatedString::formatted("Cannot create the '{}' directory because there is already a file with that name", parent_directory);
|
||||
return Error::from_string_view(formatted_error_string_holder);
|
||||
return Error::from_string_view(formatted_error_string_holder.view());
|
||||
}
|
||||
|
||||
auto maybe_error = Core::System::mkdir(LexicalPath::absolute_path(m_project->root_path(), parent_directory), 0755);
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue