mirror of
https://github.com/RGBCube/serenity
synced 2025-07-27 01:17:35 +00:00
AK+Everywhere: Disallow Error::from_string_view(FooString)
That pattern seems to show up a lot in code written by people that aren't intimately familiar with the lifetime model of Error and Strings. This commit makes the compiler detect it and present a more helpful diagnostic than "garbage string at runtime".
This commit is contained in:
parent
cc35bab143
commit
7e6341587b
7 changed files with 29 additions and 14 deletions
|
@ -45,7 +45,7 @@ static ErrorOr<int> weekday_index(StringView weekday_name)
|
|||
if (auto numeric_weekday = AK::StringUtils::convert_to_int(weekday_name); numeric_weekday.has_value())
|
||||
return numeric_weekday.value();
|
||||
|
||||
return Error::from_string_view(TRY(String::formatted("Unknown weekday name: '{}'", weekday_name)));
|
||||
return Error::from_string_view("Unknown weekday name"sv);
|
||||
}
|
||||
|
||||
static ErrorOr<int> default_weekday_start()
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue