RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 12:37:45 +00:00
Code Issues Activity Actions

AK+Everywhere: Disallow Error::from_string_view(FooString)

Browse source 
That pattern seems to show up a lot in code written by people that
aren't intimately familiar with the lifetime model of Error and Strings.
This commit makes the compiler detect it and present a more helpful
diagnostic than "garbage string at runtime".
This commit is contained in:
Ali Mohammad Pur 2023-04-27 21:21:19 +03:30 • committed by Andreas Kling
parent cc35bab143
commit 7e6341587b
7 changed files with 29 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Utilities/cal.cpp
View file

@ -45,7 +45,7 @@ static ErrorOr<int> weekday_index(StringView weekday_name)
if (auto numeric_weekday = AK::StringUtils::convert_to_int(weekday_name); numeric_weekday.has_value())
return numeric_weekday.value();
return Error::from_string_view(TRY(String::formatted("Unknown weekday name: '{}'", weekday_name)));
return Error::from_string_view("Unknown weekday name"sv);
}
static ErrorOr<int> default_weekday_start()