RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 02:47:34 +00:00
Code Issues Activity Actions

LibJS: Add support for the '#privateName in obj' expression

Browse source
This commit is contained in:
davidot 2021-10-14 02:05:24 +02:00 • committed by Linus Groh
parent 16cc82460f
commit 7e8724db71
2 changed files with 23 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

18
Userland/Libraries/LibJS/AST.cpp
View file

@ -902,6 +902,24 @@ Value BinaryExpression::execute(Interpreter& interpreter, GlobalObject& global_o
{ {
InterpreterNodeScope node_scope { interpreter, *this }; InterpreterNodeScope node_scope { interpreter, *this };
// Special case in which we cannot execute the lhs. RelationalExpression : PrivateIdentifier in ShiftExpression
// RelationalExpression : PrivateIdentifier in ShiftExpression, https://tc39.es/ecma262/#sec-relational-operators-runtime-semantics-evaluation
if (m_op == BinaryOp::In && is<PrivateIdentifier>(*m_lhs)) {
auto& private_identifier = static_cast<PrivateIdentifier const&>(*m_lhs).string();
auto rhs_result = m_rhs->execute(interpreter, global_object);
if (interpreter.exception())
return {};
if (!rhs_result.is_object()) {
interpreter.vm().throw_exception<TypeError>(global_object, ErrorType::InOperatorWithObject);
return {};
}
auto* private_environment = interpreter.vm().running_execution_context().private_environment;
VERIFY(private_environment);
auto private_name = private_environment->resolve_private_identifier(private_identifier);
return Value(rhs_result.as_object().private_element_find(private_name) != nullptr);
}
auto lhs_result = m_lhs->execute(interpreter, global_object); auto lhs_result = m_lhs->execute(interpreter, global_object);
if (interpreter.exception()) if (interpreter.exception())
return {}; return {};

5
Userland/Libraries/LibJS/Parser.cpp
View file

@ -1214,6 +1214,11 @@ Parser::PrimaryExpressionParseResult Parser::parse_primary_expression()
if (!m_state.in_generator_function_context) if (!m_state.in_generator_function_context)
goto read_as_identifier; goto read_as_identifier;
return { parse_yield_expression(), false }; return { parse_yield_expression(), false };
case TokenType::PrivateIdentifier:
VERIFY(next_token().type() == TokenType::In);
if (!is_private_identifier_valid())
syntax_error(String::formatted("Reference to undeclared private field or method '{}'", m_state.current_token.value()));
return { create_ast_node<PrivateIdentifier>({ m_state.current_token.filename(), rule_start.position(), position() }, consume().value()) };
default: default:
if (match_identifier_name()) if (match_identifier_name())
goto read_as_identifier; goto read_as_identifier;