RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 17:07:35 +00:00
Code Issues Activity Actions

LibGfx/PortableFormat: Propagate errors from read_image_data()

Browse source
This commit is contained in:
Lucas CHOLLET 2023-03-12 22:55:47 -04:00 • committed by Andreas Kling
parent 2356b48f13
commit 7ec310384a
7 changed files with 30 additions and 66 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Userland/Libraries/LibGfx/ImageFormats/PortableImageLoaderCommon.h
View file

@ -165,15 +165,10 @@ static ErrorOr<void> read_max_val(TContext& context)
}
template<typename TContext>
static bool create_bitmap(TContext& context)
static ErrorOr<void> create_bitmap(TContext& context)
{
auto bitmap_or_error = Bitmap::create(BitmapFormat::BGRx8888, { context.width, context.height });
if (bitmap_or_error.is_error()) {
context.state = TContext::State::Error;
return false;
}
context.bitmap = bitmap_or_error.release_value_but_fixme_should_propagate_errors();
return true;
context.bitmap = TRY(Bitmap::create(BitmapFormat::BGRx8888, { context.width, context.height }));
return {};
}
template<typename TContext>
@ -229,7 +224,7 @@ static bool decode(TContext& context)
return false;
}
if (!read_image_data(context))
if (read_image_data(context).is_error())
return false;
error_guard.disarm();