RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 15:37:47 +00:00
Code Issues Activity Actions

HackStudio: Get rid of m_currently_open_file member

Browse source 
It had the following FIXME:
// FIXME: This doesn't seem compatible with multiple split editors

In practice this member was used to get the filename of the currently
active edtior. So we now get it directly from the currently active
EditorWrapper.
This commit is contained in:
Itamar 2021-05-01 13:04:19 +03:00 • committed by Andreas Kling
parent 790908ffc3
commit 7f2e1991cc
5 changed files with 26 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/DevTools/HackStudio/HackStudioWidget.h
View file

@ -41,7 +41,7 @@ public:
EditorWrapper& current_editor_wrapper();
void set_current_editor_wrapper(RefPtr<EditorWrapper>);
String currently_open_file() const { return m_currently_open_file; }
const String& active_file() const { return m_current_editor_wrapper->filename(); }
void initialize_menubar(GUI::Menubar&);
Locator& locator()
@ -116,9 +116,6 @@ private:
NonnullRefPtrVector<EditorWrapper> m_all_editor_wrappers;
RefPtr<EditorWrapper> m_current_editor_wrapper;
// FIXME: This doesn't seem compatible with multiple split editors
String m_currently_open_file;
HashMap<String, NonnullRefPtr<ProjectFile>> m_open_files;
HashMap<String, NonnullRefPtr<Core::FileWatcher>> m_file_watchers;
Vector<String> m_open_files_vector; // NOTE: This contains the keys from m_open_files and m_file_watchers