RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 02:37:35 +00:00
Code Issues Activity Actions

LibJS: Disallow 'yield' identifier initializer in GeneratorFunctions

Browse source
This commit is contained in:
Matthew Olsson 2021-06-17 10:14:45 -07:00 • committed by Linus Groh
parent 9253fa1bad
commit 7f97e33778
1 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibJS/Parser.cpp
View file

@ -1409,8 +1409,10 @@ NonnullRefPtr<FunctionNodeType> Parser::parse_function_node(u8 parse_options)
consume(TokenType::Function); consume(TokenType::Function);
if (!is_generator) { if (!is_generator) {
is_generator = match(TokenType::Asterisk); is_generator = match(TokenType::Asterisk);
if (is_generator) if (is_generator) {
consume(TokenType::Asterisk); consume(TokenType::Asterisk);
parse_options = parse_options | FunctionNodeParseOptions::IsGeneratorFunction;
}
} }
if (FunctionNodeType::must_have_name() || match(TokenType::Identifier)) if (FunctionNodeType::must_have_name() || match(TokenType::Identifier))
@ -1499,6 +1501,10 @@ Vector<FunctionNode::Parameter> Parser::parse_formal_parameters(int& function_le
has_default_parameter = true; has_default_parameter = true;
function_length = parameters.size(); function_length = parameters.size();
default_value = parse_expression(2); default_value = parse_expression(2);
bool is_generator = parse_options & FunctionNodeParseOptions::IsGeneratorFunction;
if (is_generator && default_value && default_value->fast_is<Identifier>() && static_cast<Identifier&>(*default_value).string() == "yield"sv)
syntax_error("Generator function parameter initializer cannot contain a reference to an identifier named \"yield\"");
} }
parameters.append({ move(parameter), default_value, is_rest }); parameters.append({ move(parameter), default_value, is_rest });
if (match(TokenType::ParenClose)) if (match(TokenType::ParenClose))