From 7fa5f6be7d5d3032bfd194c44c278f18bd19f5a3 Mon Sep 17 00:00:00 2001
From: Idan Horowitz <idan.horowitz@gmail.com>
Date: Fri, 18 Jun 2021 15:36:55 +0300
Subject: [PATCH] CI: Remove discord build status notifications

While these look nice, they require the discord workflow to sit around
and wait for the build-and-lint workflow to finish in order to get its
status which means we waste an extra workflow runner that does nothing
for each build-and-lint run.
---
 .github/workflows/discord.yml | 21 ---------------------
 1 file changed, 21 deletions(-)

diff --git a/.github/workflows/discord.yml b/.github/workflows/discord.yml
index 0e2d29a342..a245c8d266 100644
--- a/.github/workflows/discord.yml
+++ b/.github/workflows/discord.yml
@@ -8,30 +8,9 @@ jobs:
     if: always() && github.repository == 'SerenityOS/serenity' && (github.event_name == 'pull_request_target' || (github.event_name == 'push' && github.ref == 'refs/heads/master'))
 
     steps:
-      - name: Wait for tests to finish
-        uses: IdanHo/action-wait-for-check@7b2192dd83108237d2f2e6518f6351be333a955c
-        id: wait-for-tests
-        if: ${{ (github.event['pull_request'] && github.event['action'] == 'opened' && !github.event.pull_request.draft) || github.event['commits'] }}
-        with:
-          token: ${{ secrets.GITHUB_TOKEN }}
-          excludedCheckName: "notify_discord"
-          ref: ${{ github.event.pull_request.head.sha || github.sha }}
-          timeoutSeconds: 21600
-          intervalSeconds: 100
-
       - name: Discord action notification
         env:
           DISCORD_WEBHOOK: ${{ secrets.DISCORD_WEBHOOK }}
           CUSTOM_GITHUB_EVENT_NAME: ${{ github.event_name == 'pull_request_target' && 'pull_request' || github.event_name }} # fake the event type as discord doesn't know how to parse the special pull_request_target context
         uses: IdanHo/action-discord@754598254f288e6d8e9fca637832e3c163515ba8
         if: ${{ (github.event['pull_request'] && github.event['action'] == 'opened' && !github.event.pull_request.draft) || github.event['commits'] }}
-
-      - name: Discord build status
-        env:
-          DISCORD_WEBHOOK: ${{ secrets.DISCORD_WEBHOOK }}
-          DISCORD_USERNAME: GitHub # we have to set these manually for non-default messages
-          DISCORD_AVATAR: https://github.githubassets.com/images/modules/logos_page/GitHub-Mark.png
-        uses: IdanHo/action-discord@754598254f288e6d8e9fca637832e3c163515ba8
-        if: ${{ (github.event['pull_request'] && github.event['action'] == 'opened' && !github.event.pull_request.draft) || github.event['commits'] }}
-        with:
-          args: "The build ${{ steps.wait-for-tests.outputs.conclusion == 'success' && 'passed :white_check_mark:' || 'failed :x:' }}"