1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 13:27:35 +00:00

LibSQL+SQLServer: Implement first cut of SELECT ... ORDER BY foo

Ordering is done by replacing the straight Vector holding the query
result in the SQLResult object with a dedicated Vector subclass that
inserts result rows according to their sort key using a binary search.
This is done in the ResultSet class.

There are limitations:
- "SELECT ... ORDER BY 1" (or 2 or 3 etc) is supposed to sort by the
n-th result column. This doesn't work yet
- "SELECT ... column-expression alias ... ORDER BY alias" is supposed to
sort by the column with the given alias. This doesn't work yet

What does work however is something like
```SELECT foo FROM bar SORT BY quux```
i.e. sorted by a column not in the result set. Once functions are
supported it should be possible to sort by random functions.
This commit is contained in:
Jan de Visser 2022-01-12 09:49:43 -05:00 committed by Andreas Kling
parent 53cd87cc1d
commit 7fc901d1b3
7 changed files with 205 additions and 17 deletions

View file

@ -104,7 +104,7 @@ void SQLStatement::next()
return;
}
if (m_index < m_result->results().size()) {
auto& tuple = m_result->results()[m_index++];
auto& tuple = m_result->results()[m_index++].row;
client_connection->async_next_result(statement_id(), tuple.to_string_vector());
deferred_invoke([this]() {
next();