From 7ff6d8d9e2b4c0e8c18740f721f0de4e7ce9ce33 Mon Sep 17 00:00:00 2001 From: MacDue Date: Wed, 7 Jun 2023 23:12:44 +0100 Subject: [PATCH] LibWeb: Remove rounding in CRC2D.stroke_rect() The new rasterizer can now handle floating point positions nicely so this rounding can be removed. --- .../Libraries/LibWeb/HTML/CanvasRenderingContext2D.cpp | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/Userland/Libraries/LibWeb/HTML/CanvasRenderingContext2D.cpp b/Userland/Libraries/LibWeb/HTML/CanvasRenderingContext2D.cpp index 11863844dd..55092aaa4d 100644 --- a/Userland/Libraries/LibWeb/HTML/CanvasRenderingContext2D.cpp +++ b/Userland/Libraries/LibWeb/HTML/CanvasRenderingContext2D.cpp @@ -97,11 +97,10 @@ void CanvasRenderingContext2D::stroke_rect(float x, float y, float width, float { auto& drawing_state = this->drawing_state(); - // We could remove the rounding here, but the lines look better when they have whole number pixel endpoints. - auto top_left = drawing_state.transform.map(Gfx::FloatPoint(x, y)).to_rounded(); - auto top_right = drawing_state.transform.map(Gfx::FloatPoint(x + width - 1, y)).to_rounded(); - auto bottom_left = drawing_state.transform.map(Gfx::FloatPoint(x, y + height - 1)).to_rounded(); - auto bottom_right = drawing_state.transform.map(Gfx::FloatPoint(x + width - 1, y + height - 1)).to_rounded(); + auto top_left = drawing_state.transform.map(Gfx::FloatPoint(x, y)); + auto top_right = drawing_state.transform.map(Gfx::FloatPoint(x + width - 1, y)); + auto bottom_left = drawing_state.transform.map(Gfx::FloatPoint(x, y + height - 1)); + auto bottom_right = drawing_state.transform.map(Gfx::FloatPoint(x + width - 1, y + height - 1)); Gfx::Path path; path.move_to(top_left);