RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 00:27:45 +00:00
Code Issues Activity Actions

AK+LibRegex+LibWasm: Remove the non-const COWVector::operator[]

Browse source 
This was copying the vector behind our backs, let's remove it and make
the copying explicit by putting it behind COWVector::mutable_at().
This is a further 64% performance improvement on Wasm validation.
This commit is contained in:
Ali Mohammad Pur 2024-03-11 16:55:29 +01:00 • committed by Ali Mohammad Pur
parent cced555879
commit 8003bde03d
4 changed files with 14 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

9
AK/COWVector.h
View file

@ -110,7 +110,7 @@ public:
m_detail->m_members.clear();
}
T& at(size_t index)
T& mutable_at(size_t index)
{
// We're handing out a mutable reference, so make sure we own the data exclusively.
copy();
@ -122,13 +122,6 @@ public:
return m_detail->m_members.at(index);
}
T& operator[](size_t index)
{
// We're handing out a mutable reference, so make sure we own the data exclusively.
copy();
return m_detail->m_members[index];
}
T const& operator[](size_t index) const
{
return m_detail->m_members[index];