RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 11:48:10 +00:00
Code Issues Activity Actions

SystemMonitor: Don't include the Idle Task in process statistics

Browse source 
The Idle Task is no longer displayed in the Processes tab and is not
included in the process count in the status bar.
This commit is contained in:
Tim Ledbetter 2024-01-10 19:27:29 +00:00 • committed by Andreas Kling
parent 1c1fc67f75
commit 800cb4eceb
1 changed files with 10 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Userland/Applications/SystemMonitor/ProcessModel.cpp
View file

@ -453,8 +453,10 @@ void ProcessModel::update()
HashTable<int> live_tids;
u64 total_time_scheduled_diff = 0;
size_t process_count = 0;
if (!all_processes_or_error.is_error()) {
auto all_processes = all_processes_or_error.value();
process_count = all_processes.processes.size();
if (m_has_total_scheduled_time)
total_time_scheduled_diff = all_processes.total_time_scheduled - m_total_time_scheduled;
@ -463,6 +465,13 @@ void ProcessModel::update()
m_has_total_scheduled_time = true;
for (auto const& process : all_processes.processes) {
// Don't include the Idle Task in process statistics.
static constexpr pid_t IDLE_TASK_PID = 0;
if (process.pid == IDLE_TASK_PID) {
process_count--;
continue;
}
NonnullOwnPtr<Process>* process_state = nullptr;
for (size_t i = 0; i < m_processes.size(); ++i) {
auto* other_process = &m_processes[i];
@ -607,7 +616,7 @@ void ProcessModel::update()
on_cpu_info_change(m_cpus);
if (on_state_update)
on_state_update(!all_processes_or_error.is_error() ? all_processes_or_error.value().processes.size() : 0, m_threads.size());
on_state_update(process_count, m_threads.size());
// FIXME: This is a rather hackish way of invalidating indices.
// It would be good if GUI::Model had a way to orchestrate removal/insertion while preserving indices.