RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 04:47:34 +00:00
Code Issues Activity Actions

Userland: static vs non-static constexpr variables

Browse source 
Problem:
- `static` variables consume memory and sometimes are less
  optimizable.
- `static const` variables can be `constexpr`, usually.
- `static` function-local variables require an initialization check
  every time the function is run.

Solution:
- If a global `static` variable is only used in a single function then
  move it into the function and make it non-`static` and `constexpr`.
- Make all global `static` variables `constexpr` instead of `const`.
- Change function-local `static const[expr]` variables to be just
  `constexpr`.
This commit is contained in:
Lenny Maiorani 2021-05-19 09:32:07 -06:00 • committed by Linus Groh
parent 17ff895e1c
commit 800ea8ea96
38 changed files with 192 additions and 184 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibGUI/ResizeCorner.cpp
View file

@ -12,7 +12,7 @@
namespace GUI {
static const char* s_resize_corner_shadows_data = {
static constexpr char s_resize_corner_shadows_data[] = {
" "
" ## "
" # "
@ -31,7 +31,7 @@ static const char* s_resize_corner_shadows_data = {
" "
};
static const char* s_resize_corner_highlights_data = {
static constexpr char s_resize_corner_highlights_data[] = {
" "
" "
" # "
@ -52,8 +52,8 @@ static const char* s_resize_corner_highlights_data = {
static Gfx::CharacterBitmap* s_resize_corner_shadows_bitmap;
static Gfx::CharacterBitmap* s_resize_corner_highlights_bitmap;
static const int s_resize_corner_bitmap_width = 16;
static const int s_resize_corner_bitmap_height = 16;
static constexpr int s_resize_corner_bitmap_width = 16;
static constexpr int s_resize_corner_bitmap_height = 16;
ResizeCorner::ResizeCorner()
{