mirror of
https://github.com/RGBCube/serenity
synced 2025-07-27 09:27:35 +00:00
Userland: static vs non-static constexpr variables
Problem: - `static` variables consume memory and sometimes are less optimizable. - `static const` variables can be `constexpr`, usually. - `static` function-local variables require an initialization check every time the function is run. Solution: - If a global `static` variable is only used in a single function then move it into the function and make it non-`static` and `constexpr`. - Make all global `static` variables `constexpr` instead of `const`. - Change function-local `static const[expr]` variables to be just `constexpr`.
This commit is contained in:
parent
17ff895e1c
commit
800ea8ea96
38 changed files with 192 additions and 184 deletions
|
@ -861,20 +861,20 @@ static void dequantize(JPGLoadingContext& context, Vector<Macroblock>& macrobloc
|
|||
|
||||
static void inverse_dct(const JPGLoadingContext& context, Vector<Macroblock>& macroblocks)
|
||||
{
|
||||
static const float m0 = 2.0 * cos(1.0 / 16.0 * 2.0 * M_PI);
|
||||
static const float m1 = 2.0 * cos(2.0 / 16.0 * 2.0 * M_PI);
|
||||
static const float m3 = 2.0 * cos(2.0 / 16.0 * 2.0 * M_PI);
|
||||
static const float m5 = 2.0 * cos(3.0 / 16.0 * 2.0 * M_PI);
|
||||
static const float m2 = m0 - m5;
|
||||
static const float m4 = m0 + m5;
|
||||
static const float s0 = cos(0.0 / 16.0 * M_PI) / sqrt(8);
|
||||
static const float s1 = cos(1.0 / 16.0 * M_PI) / 2.0;
|
||||
static const float s2 = cos(2.0 / 16.0 * M_PI) / 2.0;
|
||||
static const float s3 = cos(3.0 / 16.0 * M_PI) / 2.0;
|
||||
static const float s4 = cos(4.0 / 16.0 * M_PI) / 2.0;
|
||||
static const float s5 = cos(5.0 / 16.0 * M_PI) / 2.0;
|
||||
static const float s6 = cos(6.0 / 16.0 * M_PI) / 2.0;
|
||||
static const float s7 = cos(7.0 / 16.0 * M_PI) / 2.0;
|
||||
const float m0 = 2.0 * cos(1.0 / 16.0 * 2.0 * M_PI);
|
||||
const float m1 = 2.0 * cos(2.0 / 16.0 * 2.0 * M_PI);
|
||||
const float m3 = 2.0 * cos(2.0 / 16.0 * 2.0 * M_PI);
|
||||
const float m5 = 2.0 * cos(3.0 / 16.0 * 2.0 * M_PI);
|
||||
const float m2 = m0 - m5;
|
||||
const float m4 = m0 + m5;
|
||||
const float s0 = cos(0.0 / 16.0 * M_PI) / sqrt(8);
|
||||
const float s1 = cos(1.0 / 16.0 * M_PI) / 2.0;
|
||||
const float s2 = cos(2.0 / 16.0 * M_PI) / 2.0;
|
||||
const float s3 = cos(3.0 / 16.0 * M_PI) / 2.0;
|
||||
const float s4 = cos(4.0 / 16.0 * M_PI) / 2.0;
|
||||
const float s5 = cos(5.0 / 16.0 * M_PI) / 2.0;
|
||||
const float s6 = cos(6.0 / 16.0 * M_PI) / 2.0;
|
||||
const float s7 = cos(7.0 / 16.0 * M_PI) / 2.0;
|
||||
|
||||
for (u32 vcursor = 0; vcursor < context.mblock_meta.vcount; vcursor += context.vsample_factor) {
|
||||
for (u32 hcursor = 0; hcursor < context.mblock_meta.hcount; hcursor += context.hsample_factor) {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue