diff --git a/Userland/Libraries/LibJS/Runtime/CommonPropertyNames.h b/Userland/Libraries/LibJS/Runtime/CommonPropertyNames.h index 80e03f8347..e9849b9565 100644 --- a/Userland/Libraries/LibJS/Runtime/CommonPropertyNames.h +++ b/Userland/Libraries/LibJS/Runtime/CommonPropertyNames.h @@ -236,6 +236,7 @@ namespace JS { P(max) \ P(message) \ P(min) \ + P(months) \ P(multiline) \ P(name) \ P(next) \ diff --git a/Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.cpp b/Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.cpp index 7f6d72da86..41347fec09 100644 --- a/Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.cpp +++ b/Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.cpp @@ -26,6 +26,7 @@ void DurationPrototype::initialize(GlobalObject& global_object) define_direct_property(*vm.well_known_symbol_to_string_tag(), js_string(vm.heap(), "Temporal.Duration"), Attribute::Configurable); define_native_accessor(vm.names.years, years_getter, {}, Attribute::Configurable); + define_native_accessor(vm.names.months, months_getter, {}, Attribute::Configurable); } static Duration* typed_this(GlobalObject& global_object) @@ -54,4 +55,17 @@ JS_DEFINE_NATIVE_FUNCTION(DurationPrototype::years_getter) return Value(duration->years()); } +// 7.3.4 get Temporal.Duration.prototype.months, https://tc39.es/proposal-temporal/#sec-get-temporal.duration.prototype.months +JS_DEFINE_NATIVE_FUNCTION(DurationPrototype::months_getter) +{ + // 1. Let duration be the this value. + // 2. Perform ? RequireInternalSlot(duration, [[InitializedTemporalDuration]]). + auto* duration = typed_this(global_object); + if (vm.exception()) + return {}; + + // 3. Return duration.[[Months]]. + return Value(duration->months()); +} + } diff --git a/Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.h b/Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.h index ee5b1f7ab8..04f367d87b 100644 --- a/Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.h +++ b/Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.h @@ -20,6 +20,7 @@ public: private: JS_DECLARE_NATIVE_FUNCTION(years_getter); + JS_DECLARE_NATIVE_FUNCTION(months_getter); }; } diff --git a/Userland/Libraries/LibJS/Tests/builtins/Temporal/Duration/Duration.prototype.months.js b/Userland/Libraries/LibJS/Tests/builtins/Temporal/Duration/Duration.prototype.months.js new file mode 100644 index 0000000000..3e337a4fe0 --- /dev/null +++ b/Userland/Libraries/LibJS/Tests/builtins/Temporal/Duration/Duration.prototype.months.js @@ -0,0 +1,14 @@ +describe("correct behavior", () => { + test("basic functionality", () => { + const duration = new Temporal.Duration(0, 123); + expect(duration.months).toBe(123); + }); +}); + +test("errors", () => { + test("this value must be a Temporal.Duration object", () => { + expect(() => { + Reflect.get(Temporal.Duration.prototype, "months", "foo"); + }).toThrowWithMessage(TypeError, "Not a Temporal.Duration"); + }); +});