RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 11:18:11 +00:00
Code Issues Activity Actions

LibXML+LibWeb: Avoid implicit cast from StringView{}->DeprecatedString

Browse source 
This produces a (truly) null DeprecatedString, which is not expected to
occur by CharacterData (where this string ends up).
Simply pass an "empty" DeprecatedString manually instead.
This commit is contained in:
Ali Mohammad Pur 2023-01-08 14:18:33 +03:30 • committed by Andreas Kling
parent 356e58332c
commit 803ff81d4a
4 changed files with 19 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Userland/Libraries/LibWeb/XML/XMLDocumentBuilder.cpp
View file

@ -123,7 +123,7 @@ void XMLDocumentBuilder::element_end(const XML::Name& name)
m_current_node = m_current_node->parent_node();
}
void XMLDocumentBuilder::text(DeprecatedString const& data)
void XMLDocumentBuilder::text(StringView data)
{
if (m_has_error)
return;
@ -135,16 +135,22 @@ void XMLDocumentBuilder::text(DeprecatedString const& data)
text_node.set_data(text_builder.to_deprecated_string());
text_builder.clear();
} else {
auto node = m_document.create_text_node(data);
auto string = DeprecatedString::empty();
if (!data.is_null())
string = data.to_deprecated_string();
auto node = m_document.create_text_node(string);
MUST(m_current_node->append_child(node));
}
}
void XMLDocumentBuilder::comment(DeprecatedString const& data)
void XMLDocumentBuilder::comment(StringView data)
{
if (m_has_error)
return;
MUST(m_document.append_child(m_document.create_comment(data)));
auto string = DeprecatedString::empty();
if (!data.is_null())
string = data.to_deprecated_string();
MUST(m_document.append_child(m_document.create_comment(string)));
}
void XMLDocumentBuilder::document_end()