RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 22:48:11 +00:00
Code Issues Activity Actions

LibXML+LibWeb: Avoid implicit cast from StringView{}->DeprecatedString

Browse source 
This produces a (truly) null DeprecatedString, which is not expected to
occur by CharacterData (where this string ends up).
Simply pass an "empty" DeprecatedString manually instead.
This commit is contained in:
Ali Mohammad Pur 2023-01-08 14:18:33 +03:30 • committed by Andreas Kling
parent 356e58332c
commit 803ff81d4a
4 changed files with 19 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/XML/XMLDocumentBuilder.h
View file

@ -32,8 +32,8 @@ private:
virtual void set_source(DeprecatedString) override;
virtual void element_start(XML::Name const& name, HashMap<XML::Name, DeprecatedString> const& attributes) override;
virtual void element_end(XML::Name const& name) override;
virtual void text(DeprecatedString const& data) override;
virtual void comment(DeprecatedString const& data) override;
virtual void text(StringView data) override;
virtual void comment(StringView data) override;
virtual void document_end() override;
DOM::Document& m_document;