mirror of
https://github.com/RGBCube/serenity
synced 2025-07-26 06:07:44 +00:00
LibXML+LibWeb: Avoid implicit cast from StringView{}->DeprecatedString
This produces a (truly) null DeprecatedString, which is not expected to occur by CharacterData (where this string ends up). Simply pass an "empty" DeprecatedString manually instead.
This commit is contained in:
parent
356e58332c
commit
803ff81d4a
4 changed files with 19 additions and 13 deletions
|
@ -78,7 +78,7 @@ void Parser::append_node(NonnullOwnPtr<Node> node)
|
|||
}
|
||||
}
|
||||
|
||||
void Parser::append_text(DeprecatedString text)
|
||||
void Parser::append_text(StringView text)
|
||||
{
|
||||
if (m_listener) {
|
||||
m_listener->text(text);
|
||||
|
@ -111,7 +111,7 @@ void Parser::append_text(DeprecatedString text)
|
|||
});
|
||||
}
|
||||
|
||||
void Parser::append_comment(DeprecatedString text)
|
||||
void Parser::append_comment(StringView text)
|
||||
{
|
||||
if (m_listener) {
|
||||
m_listener->comment(text);
|
||||
|
@ -125,7 +125,7 @@ void Parser::append_comment(DeprecatedString text)
|
|||
|
||||
m_entered_node->content.visit(
|
||||
[&](Node::Element& node) {
|
||||
node.children.append(make<Node>(Node::Comment { move(text) }));
|
||||
node.children.append(make<Node>(Node::Comment { text }));
|
||||
},
|
||||
[&](auto&) {
|
||||
// Can't enter a text or comment node.
|
||||
|
|
|
@ -34,8 +34,8 @@ struct Listener {
|
|||
virtual void document_end() { }
|
||||
virtual void element_start(Name const&, HashMap<Name, DeprecatedString> const&) { }
|
||||
virtual void element_end(Name const&) { }
|
||||
virtual void text(DeprecatedString const&) { }
|
||||
virtual void comment(DeprecatedString const&) { }
|
||||
virtual void text(StringView) { }
|
||||
virtual void comment(StringView) { }
|
||||
virtual void error(ParseError const&) { }
|
||||
};
|
||||
|
||||
|
@ -73,8 +73,8 @@ private:
|
|||
|
||||
ErrorOr<void, ParseError> parse_internal();
|
||||
void append_node(NonnullOwnPtr<Node>);
|
||||
void append_text(DeprecatedString);
|
||||
void append_comment(DeprecatedString);
|
||||
void append_text(StringView);
|
||||
void append_comment(StringView);
|
||||
void enter_node(Node&);
|
||||
void leave_node();
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue