1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-14 23:24:57 +00:00

LibWeb: Implement HTMLDialogElement::close() for non-modal dialogs

This commit is contained in:
Tim Ledbetter 2024-02-13 22:37:16 +00:00 committed by Tim Flynn
parent cfbd14b958
commit 8042558805
4 changed files with 59 additions and 2 deletions

View file

@ -5,6 +5,7 @@
*/
#include <LibWeb/Bindings/Intrinsics.h>
#include <LibWeb/DOM/Event.h>
#include <LibWeb/HTML/HTMLDialogElement.h>
namespace Web::HTML {
@ -37,9 +38,11 @@ void HTMLDialogElement::show_modal()
}
// https://html.spec.whatwg.org/multipage/interactive-elements.html#dom-dialog-close
void HTMLDialogElement::close(Optional<String>)
void HTMLDialogElement::close(Optional<String> return_value)
{
dbgln("(STUBBED) HTMLDialogElement::close()");
// 1. If returnValue is not given, then set it to null.
// 2. Close the dialog this with returnValue.
close_the_dialog(move(return_value));
}
// https://html.spec.whatwg.org/multipage/interactive-elements.html#dom-dialog-returnvalue
@ -54,4 +57,39 @@ void HTMLDialogElement::set_return_value(String return_value)
m_return_value = move(return_value);
}
// https://html.spec.whatwg.org/multipage/interactive-elements.html#close-the-dialog
void HTMLDialogElement::close_the_dialog(Optional<String> result)
{
// 1. If subject does not have an open attribute, then return.
if (!has_attribute(AttributeNames::open))
return;
// 2. Remove subject's open attribute.
remove_attribute(AttributeNames::open);
// FIXME: 3. If the is modal flag of subject is true, then request an element to be removed from the top layer given subject.
// FIXME: 4. Let wasModal be the value of subject's is modal flag.
// FIXME: 5. Set the is modal flag of subject to false.
// 6. If result is not null, then set the returnValue attribute to result.
if (result.has_value())
set_return_value(result.release_value());
// FIXME: 7. If subject's previously focused element is not null, then:
// 1. Let element be subject's previously focused element.
// 2. Set subject's previously focused element to null.
// 3. If subject's node document's focused area of the document's DOM anchor is a shadow-including inclusive descendant of element,
// or wasModal is true, then run the focusing steps for element; the viewport should not be scrolled by doing this step.
// 8. Queue an element task on the user interaction task source given the subject element to fire an event named close at subject.
queue_an_element_task(HTML::Task::Source::UserInteraction, [this] {
auto close_event = DOM::Event::create(realm(), HTML::EventNames::close);
dispatch_event(close_event);
});
// FIXME: 9. If subject's close watcher is not null, then:
// 1. Destroy subject's close watcher.
// 2. Set subject's close watcher to null.
}
}