RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 20:57:35 +00:00
Code Issues Activity Actions

LibWeb: Make any HTMLInputElement with type != hidden focusable

Browse source 
From the HTML spec:

    Modulo platform conventions, it is suggested that the following
    elements should be considered as focusable areas and be sequentially
    focusable:

      ...
    - input elements whose type attribute are not in the Hidden state
      ...
This commit is contained in:
Linus Groh 2022-03-26 18:02:41 +00:00 • committed by Andreas Kling
parent 4923e4d406
commit 80506a161f
2 changed files with 4 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibWeb/HTML/HTMLInputElement.cpp
View file

@ -208,11 +208,6 @@ void HTMLInputElement::did_receive_focus()
browsing_context->set_cursor_position(DOM::Position { *m_text_node, 0 }); browsing_context->set_cursor_position(DOM::Position { *m_text_node, 0 });
} }
bool HTMLInputElement::is_focusable() const
{
return m_text_node;
}
void HTMLInputElement::parse_attribute(FlyString const& name, String const& value) void HTMLInputElement::parse_attribute(FlyString const& name, String const& value)
{ {
HTMLElement::parse_attribute(name, value); HTMLElement::parse_attribute(name, value);

5
Userland/Libraries/LibWeb/HTML/HTMLInputElement.h
View file

@ -78,8 +78,11 @@ public:
void did_edit_text_node(Badge<BrowsingContext>); void did_edit_text_node(Badge<BrowsingContext>);
virtual bool is_focusable() const override; // ^EventTarget
// https://html.spec.whatwg.org/multipage/interaction.html#the-tabindex-attribute:the-input-element
virtual bool is_focusable() const override { return m_type != TypeAttributeState::Hidden; }
// ^HTMLElement
virtual void parse_attribute(FlyString const&, String const&) override; virtual void parse_attribute(FlyString const&, String const&) override;
virtual void did_remove_attribute(FlyString const&) override; virtual void did_remove_attribute(FlyString const&) override;