RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 20:17:44 +00:00
Code Issues Activity Actions

LibWeb: Don't generate ::before/::after for BR elements

Browse source 
We shouldn't be putting generated pseudo elements inside elements that
can't have children in the first place.

This patch fixes two issues:
- We stop generating pseudo elements for layout nodes that can't have
  children anyway.
- We mark Layout::BreakNode as not being able to have children.
This commit is contained in:
Andreas Kling 2023-09-14 14:30:39 +02:00
parent a7c1af08ca
commit 80a78c4deb
4 changed files with 34 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Tests/LibWeb/Layout/input/br-should-not-generate-pseudo-before.html Normal file
View file

@ -0,0 +1,3 @@
<!doctype html><style>
body ::before { content: "+"; }
</style><body><p>P should generate a ::before pseudo.</p><br>BR should not!