RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 13:18:13 +00:00
Code Issues Activity Actions

Profiler: Share the mapped kernel between Profile and DisassemblyModel

Browse source 
There is no point in keeping around a separate MappedFile object for
/boot/Kernel.debug for each DisassemblyModel we create and re-parsing
the kernel image multiple times. This will significantly speed up
browsing through profile entries from the kernel in disassembly view.
This commit is contained in:
Daniel Bertalan 2021-10-26 17:35:35 +02:00 • committed by Andreas Kling
parent c19c306744
commit 80b660132c
4 changed files with 18 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Userland/DevTools/Profiler/DisassemblyModel.cpp
View file

@ -38,19 +38,12 @@ DisassemblyModel::DisassemblyModel(Profile& profile, ProfileNode& node)
: m_profile(profile)
, m_node(node)
{
OwnPtr<ELF::Image> kernel_elf;
const ELF::Image* elf;
FlatPtr base_address = 0;
auto maybe_kernel_base = Symbolication::kernel_base();
if (maybe_kernel_base.has_value() && m_node.address() >= maybe_kernel_base.value()) {
if (!m_kernel_file) {
auto file_or_error = MappedFile::map("/boot/Kernel.debug");
if (file_or_error.is_error())
return;
m_kernel_file = file_or_error.release_value();
}
kernel_elf = make<ELF::Image>((const u8*)m_kernel_file->data(), m_kernel_file->size());
elf = kernel_elf.ptr();
if (auto maybe_kernel_base = Symbolication::kernel_base(); maybe_kernel_base.has_value() && m_node.address() >= *maybe_kernel_base) {
if (!g_kernel_debuginfo_object.has_value())
return;
elf = &g_kernel_debuginfo_object->elf;
base_address = maybe_kernel_base.value();
} else {
auto& process = node.process();