mirror of
https://github.com/RGBCube/serenity
synced 2025-07-28 05:37:44 +00:00
Everywhere: Pass AK::ReadonlyBytes by value
This commit is contained in:
parent
8b1108e485
commit
80d4e830a0
42 changed files with 96 additions and 96 deletions
|
@ -34,7 +34,7 @@ String OutlineItem::to_string(int indent) const
|
|||
return builder.to_string();
|
||||
}
|
||||
|
||||
RefPtr<Document> Document::create(ReadonlyBytes const& bytes)
|
||||
RefPtr<Document> Document::create(ReadonlyBytes bytes)
|
||||
{
|
||||
auto parser = adopt_ref(*new Parser({}, bytes));
|
||||
auto document = adopt_ref(*new Document(parser));
|
||||
|
|
|
@ -72,7 +72,7 @@ struct OutlineDict final : public RefCounted<OutlineDict> {
|
|||
|
||||
class Document final : public RefCounted<Document> {
|
||||
public:
|
||||
static RefPtr<Document> create(ReadonlyBytes const& bytes);
|
||||
static RefPtr<Document> create(ReadonlyBytes bytes);
|
||||
|
||||
ALWAYS_INLINE RefPtr<OutlineDict> const& outline() const { return m_outline; }
|
||||
|
||||
|
|
|
@ -11,7 +11,7 @@
|
|||
|
||||
namespace PDF {
|
||||
|
||||
Optional<ByteBuffer> Filter::decode(ReadonlyBytes const& bytes, FlyString const& encoding_type)
|
||||
Optional<ByteBuffer> Filter::decode(ReadonlyBytes bytes, FlyString const& encoding_type)
|
||||
{
|
||||
if (encoding_type == CommonNames::ASCIIHexDecode)
|
||||
return decode_ascii_hex(bytes);
|
||||
|
@ -37,7 +37,7 @@ Optional<ByteBuffer> Filter::decode(ReadonlyBytes const& bytes, FlyString const&
|
|||
return {};
|
||||
}
|
||||
|
||||
Optional<ByteBuffer> Filter::decode_ascii_hex(ReadonlyBytes const& bytes)
|
||||
Optional<ByteBuffer> Filter::decode_ascii_hex(ReadonlyBytes bytes)
|
||||
{
|
||||
if (bytes.size() % 2 == 0)
|
||||
return decode_hex(bytes);
|
||||
|
@ -68,7 +68,7 @@ Optional<ByteBuffer> Filter::decode_ascii_hex(ReadonlyBytes const& bytes)
|
|||
return { move(output) };
|
||||
};
|
||||
|
||||
Optional<ByteBuffer> Filter::decode_ascii85(ReadonlyBytes const& bytes)
|
||||
Optional<ByteBuffer> Filter::decode_ascii85(ReadonlyBytes bytes)
|
||||
{
|
||||
Vector<u8> buff;
|
||||
buff.ensure_capacity(bytes.size());
|
||||
|
@ -123,13 +123,13 @@ Optional<ByteBuffer> Filter::decode_ascii85(ReadonlyBytes const& bytes)
|
|||
return ByteBuffer::copy(buff.span());
|
||||
};
|
||||
|
||||
Optional<ByteBuffer> Filter::decode_lzw(ReadonlyBytes const&)
|
||||
Optional<ByteBuffer> Filter::decode_lzw(ReadonlyBytes)
|
||||
{
|
||||
dbgln("LZW decoding is not supported");
|
||||
VERIFY_NOT_REACHED();
|
||||
};
|
||||
|
||||
Optional<ByteBuffer> Filter::decode_flate(ReadonlyBytes const& bytes)
|
||||
Optional<ByteBuffer> Filter::decode_flate(ReadonlyBytes bytes)
|
||||
{
|
||||
// FIXME: The spec says Flate decoding is "based on" zlib, does that mean they
|
||||
// aren't exactly the same?
|
||||
|
@ -139,37 +139,37 @@ Optional<ByteBuffer> Filter::decode_flate(ReadonlyBytes const& bytes)
|
|||
return buff.value();
|
||||
};
|
||||
|
||||
Optional<ByteBuffer> Filter::decode_run_length(ReadonlyBytes const&)
|
||||
Optional<ByteBuffer> Filter::decode_run_length(ReadonlyBytes)
|
||||
{
|
||||
// FIXME: Support RunLength decoding
|
||||
TODO();
|
||||
};
|
||||
|
||||
Optional<ByteBuffer> Filter::decode_ccitt(ReadonlyBytes const&)
|
||||
Optional<ByteBuffer> Filter::decode_ccitt(ReadonlyBytes)
|
||||
{
|
||||
// FIXME: Support CCITT decoding
|
||||
TODO();
|
||||
};
|
||||
|
||||
Optional<ByteBuffer> Filter::decode_jbig2(ReadonlyBytes const&)
|
||||
Optional<ByteBuffer> Filter::decode_jbig2(ReadonlyBytes)
|
||||
{
|
||||
// FIXME: Support JBIG2 decoding
|
||||
TODO();
|
||||
};
|
||||
|
||||
Optional<ByteBuffer> Filter::decode_dct(ReadonlyBytes const&)
|
||||
Optional<ByteBuffer> Filter::decode_dct(ReadonlyBytes)
|
||||
{
|
||||
// FIXME: Support dct decoding
|
||||
TODO();
|
||||
};
|
||||
|
||||
Optional<ByteBuffer> Filter::decode_jpx(ReadonlyBytes const&)
|
||||
Optional<ByteBuffer> Filter::decode_jpx(ReadonlyBytes)
|
||||
{
|
||||
// FIXME: Support JPX decoding
|
||||
TODO();
|
||||
};
|
||||
|
||||
Optional<ByteBuffer> Filter::decode_crypt(ReadonlyBytes const&)
|
||||
Optional<ByteBuffer> Filter::decode_crypt(ReadonlyBytes)
|
||||
{
|
||||
// FIXME: Support Crypt decoding
|
||||
TODO();
|
||||
|
|
|
@ -13,19 +13,19 @@ namespace PDF {
|
|||
|
||||
class Filter {
|
||||
public:
|
||||
static Optional<ByteBuffer> decode(ReadonlyBytes const& bytes, FlyString const& encoding_type);
|
||||
static Optional<ByteBuffer> decode(ReadonlyBytes bytes, FlyString const& encoding_type);
|
||||
|
||||
private:
|
||||
static Optional<ByteBuffer> decode_ascii_hex(ReadonlyBytes const& bytes);
|
||||
static Optional<ByteBuffer> decode_ascii85(ReadonlyBytes const& bytes);
|
||||
static Optional<ByteBuffer> decode_lzw(ReadonlyBytes const& bytes);
|
||||
static Optional<ByteBuffer> decode_flate(ReadonlyBytes const& bytes);
|
||||
static Optional<ByteBuffer> decode_run_length(ReadonlyBytes const& bytes);
|
||||
static Optional<ByteBuffer> decode_ccitt(ReadonlyBytes const& bytes);
|
||||
static Optional<ByteBuffer> decode_jbig2(ReadonlyBytes const& bytes);
|
||||
static Optional<ByteBuffer> decode_dct(ReadonlyBytes const& bytes);
|
||||
static Optional<ByteBuffer> decode_jpx(ReadonlyBytes const& bytes);
|
||||
static Optional<ByteBuffer> decode_crypt(ReadonlyBytes const& bytes);
|
||||
static Optional<ByteBuffer> decode_ascii_hex(ReadonlyBytes bytes);
|
||||
static Optional<ByteBuffer> decode_ascii85(ReadonlyBytes bytes);
|
||||
static Optional<ByteBuffer> decode_lzw(ReadonlyBytes bytes);
|
||||
static Optional<ByteBuffer> decode_flate(ReadonlyBytes bytes);
|
||||
static Optional<ByteBuffer> decode_run_length(ReadonlyBytes bytes);
|
||||
static Optional<ByteBuffer> decode_ccitt(ReadonlyBytes bytes);
|
||||
static Optional<ByteBuffer> decode_jbig2(ReadonlyBytes bytes);
|
||||
static Optional<ByteBuffer> decode_dct(ReadonlyBytes bytes);
|
||||
static Optional<ByteBuffer> decode_jpx(ReadonlyBytes bytes);
|
||||
static Optional<ByteBuffer> decode_crypt(ReadonlyBytes bytes);
|
||||
};
|
||||
|
||||
}
|
||||
|
|
|
@ -157,7 +157,7 @@ private:
|
|||
|
||||
class PlainTextStreamObject final : public StreamObject {
|
||||
public:
|
||||
PlainTextStreamObject(NonnullRefPtr<DictObject> const& dict, ReadonlyBytes const& bytes)
|
||||
PlainTextStreamObject(NonnullRefPtr<DictObject> const& dict, ReadonlyBytes bytes)
|
||||
: StreamObject(dict)
|
||||
, m_bytes(bytes)
|
||||
{
|
||||
|
|
|
@ -23,18 +23,18 @@ static NonnullRefPtr<T> make_object(Args... args) requires(IsBaseOf<Object, T>)
|
|||
return adopt_ref(*new T(forward<Args>(args)...));
|
||||
}
|
||||
|
||||
Vector<Command> Parser::parse_graphics_commands(ReadonlyBytes const& bytes)
|
||||
Vector<Command> Parser::parse_graphics_commands(ReadonlyBytes bytes)
|
||||
{
|
||||
auto parser = adopt_ref(*new Parser(bytes));
|
||||
return parser->parse_graphics_commands();
|
||||
}
|
||||
|
||||
Parser::Parser(Badge<Document>, ReadonlyBytes const& bytes)
|
||||
Parser::Parser(Badge<Document>, ReadonlyBytes bytes)
|
||||
: m_reader(bytes)
|
||||
{
|
||||
}
|
||||
|
||||
Parser::Parser(ReadonlyBytes const& bytes)
|
||||
Parser::Parser(ReadonlyBytes bytes)
|
||||
: m_reader(bytes)
|
||||
{
|
||||
}
|
||||
|
@ -408,7 +408,7 @@ RefPtr<DictObject> Parser::parse_file_trailer()
|
|||
return dict;
|
||||
}
|
||||
|
||||
Optional<Parser::PageOffsetHintTable> Parser::parse_page_offset_hint_table(ReadonlyBytes const& hint_stream_bytes)
|
||||
Optional<Parser::PageOffsetHintTable> Parser::parse_page_offset_hint_table(ReadonlyBytes hint_stream_bytes)
|
||||
{
|
||||
if (hint_stream_bytes.size() < sizeof(PageOffsetHintTable))
|
||||
return {};
|
||||
|
@ -456,7 +456,7 @@ Optional<Parser::PageOffsetHintTable> Parser::parse_page_offset_hint_table(Reado
|
|||
return hint_table;
|
||||
}
|
||||
|
||||
Optional<Vector<Parser::PageOffsetHintTableEntry>> Parser::parse_all_page_offset_hint_table_entries(PageOffsetHintTable const& hint_table, ReadonlyBytes const& hint_stream_bytes)
|
||||
Optional<Vector<Parser::PageOffsetHintTableEntry>> Parser::parse_all_page_offset_hint_table_entries(PageOffsetHintTable const& hint_table, ReadonlyBytes hint_stream_bytes)
|
||||
{
|
||||
InputMemoryStream input_stream(hint_stream_bytes);
|
||||
input_stream.seek(sizeof(PageOffsetHintTable));
|
||||
|
|
|
@ -24,9 +24,9 @@ public:
|
|||
Linearized,
|
||||
};
|
||||
|
||||
static Vector<Command> parse_graphics_commands(ReadonlyBytes const&);
|
||||
static Vector<Command> parse_graphics_commands(ReadonlyBytes);
|
||||
|
||||
Parser(Badge<Document>, ReadonlyBytes const&);
|
||||
Parser(Badge<Document>, ReadonlyBytes);
|
||||
|
||||
[[nodiscard]] ALWAYS_INLINE RefPtr<DictObject> const& trailer() const { return m_trailer; }
|
||||
void set_document(RefPtr<Document> const&);
|
||||
|
@ -86,15 +86,15 @@ private:
|
|||
friend struct AK::Formatter<PageOffsetHintTable>;
|
||||
friend struct AK::Formatter<PageOffsetHintTableEntry>;
|
||||
|
||||
explicit Parser(ReadonlyBytes const&);
|
||||
explicit Parser(ReadonlyBytes);
|
||||
|
||||
bool parse_header();
|
||||
LinearizationResult initialize_linearization_dict();
|
||||
bool initialize_linearized_xref_table();
|
||||
bool initialize_non_linearized_xref_table();
|
||||
bool initialize_hint_tables();
|
||||
Optional<PageOffsetHintTable> parse_page_offset_hint_table(ReadonlyBytes const& hint_stream_bytes);
|
||||
Optional<Vector<PageOffsetHintTableEntry>> parse_all_page_offset_hint_table_entries(PageOffsetHintTable const&, ReadonlyBytes const& hint_stream_bytes);
|
||||
Optional<PageOffsetHintTable> parse_page_offset_hint_table(ReadonlyBytes hint_stream_bytes);
|
||||
Optional<Vector<PageOffsetHintTableEntry>> parse_all_page_offset_hint_table_entries(PageOffsetHintTable const&, ReadonlyBytes hint_stream_bytes);
|
||||
RefPtr<XRefTable> parse_xref_table();
|
||||
RefPtr<DictObject> parse_file_trailer();
|
||||
|
||||
|
|
|
@ -16,12 +16,12 @@ namespace PDF {
|
|||
|
||||
class Reader {
|
||||
public:
|
||||
explicit Reader(ReadonlyBytes const& bytes)
|
||||
explicit Reader(ReadonlyBytes bytes)
|
||||
: m_bytes(bytes)
|
||||
{
|
||||
}
|
||||
|
||||
ALWAYS_INLINE ReadonlyBytes const& bytes() const { return m_bytes; }
|
||||
ALWAYS_INLINE ReadonlyBytes bytes() const { return m_bytes; }
|
||||
ALWAYS_INLINE size_t offset() const { return m_offset; }
|
||||
|
||||
bool done() const
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue