From 80e12999c44fee98c5936fc0b4bc10a4c487ea0a Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Wed, 28 Oct 2020 21:21:50 +0100 Subject: [PATCH] LibGUI: Model-less views should not swallow key events At least pass them up to GUI::Widget so they can be handled there. --- Libraries/LibGUI/ListView.cpp | 2 +- Libraries/LibGUI/TableView.cpp | 2 +- Libraries/LibGUI/TreeView.cpp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Libraries/LibGUI/ListView.cpp b/Libraries/LibGUI/ListView.cpp index 59eeb0eae0..916c95511a 100644 --- a/Libraries/LibGUI/ListView.cpp +++ b/Libraries/LibGUI/ListView.cpp @@ -196,7 +196,7 @@ void ListView::mousemove_event(MouseEvent& event) void ListView::keydown_event(KeyEvent& event) { if (!model()) - return; + return AbstractView::keydown_event(event); if (event.key() == KeyCode::Key_Escape) { if (on_escape_pressed) diff --git a/Libraries/LibGUI/TableView.cpp b/Libraries/LibGUI/TableView.cpp index d4be5bd613..ff0b3459b8 100644 --- a/Libraries/LibGUI/TableView.cpp +++ b/Libraries/LibGUI/TableView.cpp @@ -170,7 +170,7 @@ void TableView::paint_event(PaintEvent& event) void TableView::keydown_event(KeyEvent& event) { if (!model()) - return; + return AbstractTableView::keydown_event(event); AbstractTableView::keydown_event(event); diff --git a/Libraries/LibGUI/TreeView.cpp b/Libraries/LibGUI/TreeView.cpp index 45e3da5452..d09e6ed40b 100644 --- a/Libraries/LibGUI/TreeView.cpp +++ b/Libraries/LibGUI/TreeView.cpp @@ -433,7 +433,7 @@ void TreeView::did_update_selection() void TreeView::keydown_event(KeyEvent& event) { if (!model()) - return; + return AbstractTableView::keydown_event(event); if (event.key() == KeyCode::Key_Space) { if (model()->row_count(cursor_index()))