From 80ea6e664d32522c6e2bfa3f638c669237d56c5b Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Mon, 6 Dec 2021 12:09:39 -0500 Subject: [PATCH] LibUnicode: Do not set day period format length for {ampm} segments TR-35 does define lengths for {ampm}, but they are unused by ECMA-402. To the contrary, defining the day_period length for this segment will prevent BasicFormatMatcher from ever selecting a pattern that contains this segment. Instead, ECMA-402 will only use the short length for {ampm} segments. --- .../LibUnicode/GenerateUnicodeDateTimeFormat.cpp | 7 ------- 1 file changed, 7 deletions(-) diff --git a/Meta/Lagom/Tools/CodeGenerators/LibUnicode/GenerateUnicodeDateTimeFormat.cpp b/Meta/Lagom/Tools/CodeGenerators/LibUnicode/GenerateUnicodeDateTimeFormat.cpp index 57c32cdca1..8f4a268735 100644 --- a/Meta/Lagom/Tools/CodeGenerators/LibUnicode/GenerateUnicodeDateTimeFormat.cpp +++ b/Meta/Lagom/Tools/CodeGenerators/LibUnicode/GenerateUnicodeDateTimeFormat.cpp @@ -368,13 +368,6 @@ static Optional parse_date_time_pattern(String pattern else if (all_of(segment, is_any_of("ab"sv))) { builder.append("{ampm}"); hour12 = true; - - if (segment.length() == 4) - format.day_period = CalendarPatternStyle::Long; - else if (segment.length() == 5) - format.day_period = CalendarPatternStyle::Narrow; - else - format.day_period = CalendarPatternStyle::Short; } else if (all_of(segment, is_char('B'))) { builder.append("{dayPeriod}"); hour12 = true;