mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 16:57:35 +00:00
LibJS: Add descriptive output to test-commons expect().toThrow()
This (and still some other methods) just say Expectation error leaving the user completely in the dark whether the method threw at all. And since we have nice function printing now we can just toString the function since most are lambda's.
This commit is contained in:
parent
e3de568a45
commit
80f23abd0a
1 changed files with 20 additions and 4 deletions
|
@ -306,14 +306,30 @@ class ExpectationError extends Error {
|
|||
threw = false;
|
||||
} catch (e) {
|
||||
if (typeof value === "string") {
|
||||
this.__expect(e.message.includes(value));
|
||||
this.__expect(
|
||||
e.message.includes(value),
|
||||
`Expected ${this.target.toString()} to throw and message to include "${value}" but message "${
|
||||
e.message
|
||||
}" did not contain it`
|
||||
);
|
||||
} else if (typeof value === "function") {
|
||||
this.__expect(e instanceof value);
|
||||
this.__expect(
|
||||
e instanceof value,
|
||||
`Expected ${this.target.toString()} to throw and be of type ${value} but it threw ${e}`
|
||||
);
|
||||
} else if (typeof value === "object") {
|
||||
this.__expect(e.message === value.message);
|
||||
this.__expect(
|
||||
e.message === value.message,
|
||||
`Expected ${this.target.toString()} to throw and message to be ${value} but it threw with message ${
|
||||
e.message
|
||||
}`
|
||||
);
|
||||
}
|
||||
}
|
||||
this.__expect(threw);
|
||||
this.__expect(
|
||||
threw,
|
||||
`Expected ${this.target.toString()} to throw but it didn't throw anything`
|
||||
);
|
||||
});
|
||||
}
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue