RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 05:27:46 +00:00
Code Issues Activity Actions

Kernel: Remove colonel special-case from Process::for_each_thread

Browse source 
Since each Process now has its own list of threads, we don't need
to treat colonel any different anymore. This also means that it
reports all kernel threads, not just the idle threads.
This commit is contained in:
Tom 2021-01-27 22:29:17 -07:00 • committed by Andreas Kling
parent 985ce3b701
commit 8104abf640
1 changed files with 5 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

21
Kernel/Process.h
View file

@ -700,22 +700,11 @@ inline void Process::for_each_child(Callback callback)
template<typename Callback>
inline IterationDecision Process::for_each_thread(Callback callback) const
{
if (pid() == 0) {
// NOTE: Special case the colonel process, since its main thread is not in the global thread table.
Processor::for_each(
[&](Processor& proc) -> IterationDecision {
auto idle_thread = proc.idle_thread();
if (idle_thread != nullptr)
return callback(*idle_thread);
return IterationDecision::Continue;
});
} else {
ScopedSpinLock thread_list_lock(m_thread_list_lock);
for (auto& thread : m_thread_list) {
IterationDecision decision = callback(thread);
if (decision != IterationDecision::Continue)
return decision;
}
ScopedSpinLock thread_list_lock(m_thread_list_lock);
for (auto& thread : m_thread_list) {
IterationDecision decision = callback(thread);
if (decision != IterationDecision::Continue)
return decision;
}
return IterationDecision::Continue;
}