RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 19:17:44 +00:00
Code Issues Activity Actions

Browser: Make paste access to Clipboard atomic

Browse source 
This avoids data race issues and saves a synchronous request to the
ClipboardServer.
This commit is contained in:
Ben Wiederhake 2021-11-20 14:44:31 +01:00 • committed by Linus Groh
parent d29f094ffa
commit 81128c5100
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Applications/Browser/Tab.cpp
View file

@ -136,9 +136,10 @@ Tab::Tab(BrowserWindow& window)
};
m_location_box->add_custom_context_menu_action(GUI::Action::create("Paste && Go", [this](auto&) {
if (!GUI::Clipboard::the().mime_type().starts_with("text/"))
auto [data, mime_type, _] = GUI::Clipboard::the().data_and_type();
if (!mime_type.starts_with("text/"))
return;
auto const& paste_text = GUI::Clipboard::the().data();
auto const& paste_text = data;
if (paste_text.is_empty())
return;
m_location_box->set_text(paste_text);