RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 16:57:34 +00:00
Code Issues Activity Actions

LibAudio: Initialize m_stream before parsing a FLAC header

Browse source 
Before this change opening the file in the system resulted in crash
caused by assertion saying:

  SoundPlayer(32:32): ASSERTION FAILED: m_ptr
  ../.././AK/OwnPtr.h:139
  [#0 SoundPlayer(32:32)]: Terminating SoundPlayer(32) due to signal 6
  [#0 FinalizerTask(4:4)]: 0xdeadc0de

The issue was that 845d403b8c started
using m_stream in the parse_header() function, but that variable wasn't
initialized if the Loader plugin was created using a file path
(which is used everywhere except for the fuzz testing),
resulting in a crash mentioned above.
This commit is contained in:
Karol Kosek 2021-08-03 01:08:21 +02:00 • committed by Andreas Kling
parent 07cc7eed29
commit 81261bc169
1 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibAudio/FlacLoader.cpp
View file

@ -28,11 +28,15 @@ FlacLoaderPlugin::FlacLoaderPlugin(const StringView& path)
return;
}
m_stream = make<FlacInputStream>(Core::InputFileStream(*m_file));
if (!m_stream) {
m_error_string = String::formatted("Can't open memory stream");
return;
}
m_valid = parse_header();
if (!m_valid)
return;
m_stream = make<FlacInputStream>(Core::InputFileStream(*m_file));
reset();
if (!m_valid)
return;