RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 18:37:35 +00:00
Code Issues Activity Actions

LibDebug: Handle DWARF 4 address ranges

Browse source 
The format of the address range section is different between DWARF
version 4 and version 5. This meant that we parsed programs compiled
with `-gdwarf-4` incorrectly.
This commit is contained in:
Daniel Bertalan 2021-12-05 08:45:05 +01:00 • committed by Brian Gianforcaro
parent 7546295abe
commit 815f15f82c
5 changed files with 70 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

32
Userland/Libraries/LibDebug/Dwarf/AddressRanges.cpp
View file

@ -9,14 +9,14 @@
namespace Debug::Dwarf {
AddressRanges::AddressRanges(ReadonlyBytes range_lists_data, size_t offset, CompilationUnit const& compilation_unit)
AddressRangesV5::AddressRangesV5(ReadonlyBytes range_lists_data, size_t offset, CompilationUnit const& compilation_unit)
: m_range_lists_stream(range_lists_data)
, m_compilation_unit(compilation_unit)
{
m_range_lists_stream.seek(offset);
}
void AddressRanges::for_each_range(Function<void(Range)> callback)
void AddressRangesV5::for_each_range(Function<void(Range)> callback)
{
// Dwarf version 5, section 2.17.3 "Non-Contiguous Address Ranges"
@ -86,4 +86,32 @@ void AddressRanges::for_each_range(Function<void(Range)> callback)
}
}
AddressRangesV4::AddressRangesV4(ReadonlyBytes ranges_data, size_t offset, CompilationUnit const& compilation_unit)
: m_ranges_stream(ranges_data)
, m_compilation_unit(compilation_unit)
{
m_ranges_stream.seek(offset);
}
void AddressRangesV4::for_each_range(Function<void(Range)> callback)
{
// Dwarf version 4, section 2.17.3 "Non-Contiguous Address Ranges"
Optional<FlatPtr> current_base_address;
while (!m_ranges_stream.eof() && !m_ranges_stream.has_any_error()) {
FlatPtr begin, end;
m_ranges_stream >> begin >> end;
if (begin == 0 && end == 0) {
// end of list entry
return;
} else if (begin == explode_byte(0xff)) {
current_base_address = end;
} else {
FlatPtr base = current_base_address.value_or(m_compilation_unit.base_address().value_or(0));
callback({ base + begin, base + end });
}
}
}
}