RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 19:07:35 +00:00
Code Issues Activity Actions

LibDebug: Handle DWARF 4 address ranges

Browse source 
The format of the address range section is different between DWARF
version 4 and version 5. This meant that we parsed programs compiled
with `-gdwarf-4` incorrectly.
This commit is contained in:
Daniel Bertalan 2021-12-05 08:45:05 +01:00 • committed by Brian Gianforcaro
parent 7546295abe
commit 815f15f82c
5 changed files with 70 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

17
Userland/Libraries/LibDebug/Dwarf/DwarfInfo.cpp
View file

@ -25,6 +25,7 @@ DwarfInfo::DwarfInfo(ELF::Image const& elf)
m_debug_range_lists_data = section_data(".debug_rnglists"sv);
m_debug_str_offsets_data = section_data(".debug_str_offsets"sv);
m_debug_addr_data = section_data(".debug_addr"sv);
m_debug_ranges_data = section_data(".debug_ranges"sv);
populate_compilation_units();
}
@ -346,11 +347,19 @@ void DwarfInfo::build_cached_dies() const
auto offsets = reinterpret_cast<u32 const*>(debug_range_lists_data().offset(base));
offset = offsets[index] + base;
}
AddressRanges address_ranges(debug_range_lists_data(), offset, die.compilation_unit());
Vector<DIERange> entries;
address_ranges.for_each_range([&entries](auto range) {
entries.empend(range.start, range.end);
});
if (die.compilation_unit().dwarf_version() == 5) {
AddressRangesV5 address_ranges(debug_range_lists_data(), offset, die.compilation_unit());
address_ranges.for_each_range([&entries](auto range) {
entries.empend(range.start, range.end);
});
} else {
AddressRangesV4 address_ranges(debug_ranges_data(), offset, die.compilation_unit());
address_ranges.for_each_range([&entries](auto range) {
entries.empend(range.start, range.end);
});
}
return entries;
}