RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 10:22:45 +00:00
Code Issues Activity Actions

Kernel: Clarify IDEChannel function that switches current channel

Browse source 
Rename wait_until_not_busy() => select_device_and_wait_until_not_busy()
to make it more obvious what this thing is doing.
This commit is contained in:
Andreas Kling 2022-01-12 01:20:30 +01:00
parent 1ca8bc81a5
commit 8177e7eb22
2 changed files with 11 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Kernel/Storage/ATA/IDEChannel.h
View file

@ -44,6 +44,11 @@ public:
Secondary
};
enum class DeviceType : u8 {
Master,
Slave,
};
struct IOAddressGroup {
IOAddressGroup(IOAddress io_base, IOAddress control_base, IOAddress bus_master_base)
: m_io_base(io_base)
@ -127,7 +132,7 @@ protected:
StringView channel_type_string() const;
void try_disambiguate_error();
bool wait_until_not_busy(bool slave, size_t milliseconds_timeout);
bool select_device_and_wait_until_not_busy(DeviceType, size_t milliseconds_timeout);
bool wait_until_not_busy(size_t milliseconds_timeout);
void start_request(AsyncBlockDeviceRequest&, bool, u16);