RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 06:27:45 +00:00
Code Issues Activity Actions

LibCore+RequestServer: Ignore callbacks for cancelled network jobs

Browse source 
Also cancel the jobs when they're destroyed.
This makes sure that jobs whose owners have discarded don't end up
crashing because of a did_fail().
This commit is contained in:
Ali Mohammad Pur 2021-09-19 18:18:19 +04:30 • committed by Ali Mohammad Pur
parent 436693c0c9
commit 81a0301d4d
4 changed files with 12 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Services/RequestServer/HttpRequest.cpp
View file

@ -22,7 +22,7 @@ HttpRequest::~HttpRequest()
{
m_job->on_finish = nullptr;
m_job->on_progress = nullptr;
m_job->shutdown();
m_job->cancel();
}
NonnullOwnPtr<HttpRequest> HttpRequest::create_with_job(Badge<HttpProtocol>&&, ClientConnection& client, NonnullRefPtr<HTTP::HttpJob> job, NonnullOwnPtr<OutputFileStream>&& output_stream)