RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 10:58:12 +00:00
Code Issues Activity Actions

mount: Exit without error when handling mount all on system boot

Browse source 
At the point at which `mount -a` is executed by SystemServer, the
/proc fs is not yet mounted. That means that opening /proc/fd in
the `print_mounts()` function will always fail with an error.

    0.976 mount(8:8): Exiting with runtime error:
                      No such file or directory (errno=2)

The fix is simple, just return gracefully after we execute mount all.
This commit is contained in:
Brian Gianforcaro 2022-02-01 23:02:35 -08:00 • committed by Andreas Kling
parent d85f062990
commit 8215b99df1
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Utilities/mount.cpp
View file

@ -167,8 +167,10 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
args_parser.add_option(should_mount_all, "Mount all file systems listed in /etc/fstab", nullptr, 'a'); args_parser.add_option(should_mount_all, "Mount all file systems listed in /etc/fstab", nullptr, 'a');
args_parser.parse(arguments); args_parser.parse(arguments);
if (should_mount_all) if (should_mount_all) {
TRY(mount_all()); TRY(mount_all());
return 0;
}
if (source.is_empty() && mountpoint.is_empty()) if (source.is_empty() && mountpoint.is_empty())
TRY(print_mounts()); TRY(print_mounts());