From 82495083c3c809c4b77bc68ba5e875e6eaf30a64 Mon Sep 17 00:00:00 2001 From: Andrew Kaster Date: Mon, 7 Aug 2023 14:54:36 -0600 Subject: [PATCH] Ladybird: Ensure selected new tab URL is a valid URL before saving --- Ladybird/Qt/SettingsDialog.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Ladybird/Qt/SettingsDialog.cpp b/Ladybird/Qt/SettingsDialog.cpp index 3b3e8aa620..2890865fae 100644 --- a/Ladybird/Qt/SettingsDialog.cpp +++ b/Ladybird/Qt/SettingsDialog.cpp @@ -6,6 +6,8 @@ #include "SettingsDialog.h" #include "Settings.h" +#include "StringUtils.h" +#include #include #include @@ -43,7 +45,9 @@ void SettingsDialog::closeEvent(QCloseEvent* event) void SettingsDialog::save() { - // FIXME: Validate data. + auto url_string = MUST(ak_string_from_qstring(m_new_tab_page->text())); + if (!URL(url_string).is_valid()) + return; s_settings->set_new_tab_page(m_new_tab_page->text()); }