RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 11:28:12 +00:00
Code Issues Activity Actions

Kernel: Use StringView more in Inode and subclasses.

Browse source
This commit is contained in:
Andreas Kling 2019-06-09 10:25:19 +02:00
parent cdb44be703
commit 8258b699db
7 changed files with 14 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Kernel/FileSystem/Ext2FileSystem.cpp
View file

@ -704,7 +704,7 @@ bool Ext2FSInode::traverse_as_directory(Function<bool(const FS::DirectoryEntry&)
return true;
}
KResult Ext2FSInode::add_child(InodeIdentifier child_id, const String& name, mode_t mode)
KResult Ext2FSInode::add_child(InodeIdentifier child_id, const StringView& name, mode_t mode)
{
LOCKER(m_lock);
ASSERT(is_directory());
@ -739,7 +739,7 @@ KResult Ext2FSInode::add_child(InodeIdentifier child_id, const String& name, mod
return KSuccess;
}
KResult Ext2FSInode::remove_child(const String& name)
KResult Ext2FSInode::remove_child(const StringView& name)
{
LOCKER(m_lock);
#ifdef EXT2_DEBUG

4
Kernel/FileSystem/Ext2FileSystem.h
View file

@ -31,8 +31,8 @@ private:
virtual InodeIdentifier lookup(StringView name) override;
virtual void flush_metadata() override;
virtual ssize_t write_bytes(off_t, ssize_t, const byte* data, FileDescription*) override;
virtual KResult add_child(InodeIdentifier child_id, const String& name, mode_t) override;
virtual KResult remove_child(const String& name) override;
virtual KResult add_child(InodeIdentifier child_id, const StringView& name, mode_t) override;
virtual KResult remove_child(const StringView& name) override;
virtual int set_atime(time_t) override;
virtual int set_ctime(time_t) override;
virtual int set_mtime(time_t) override;

4
Kernel/FileSystem/Inode.h
View file

@ -43,8 +43,8 @@ public:
virtual bool traverse_as_directory(Function<bool(const FS::DirectoryEntry&)>) const = 0;
virtual InodeIdentifier lookup(StringView name) = 0;
virtual ssize_t write_bytes(off_t, ssize_t, const byte* data, FileDescription*) = 0;
virtual KResult add_child(InodeIdentifier child_id, const String& name, mode_t) = 0;
virtual KResult remove_child(const String& name) = 0;
virtual KResult add_child(InodeIdentifier child_id, const StringView& name, mode_t) = 0;
virtual KResult remove_child(const StringView& name) = 0;
virtual size_t directory_entry_count() const = 0;
virtual KResult chmod(mode_t) = 0;
virtual KResult chown(uid_t, gid_t) = 0;

4
Kernel/FileSystem/ProcFS.cpp
View file

@ -1047,14 +1047,14 @@ ssize_t ProcFSInode::write_bytes(off_t offset, ssize_t size, const byte* buffer,
return 0;
}
KResult ProcFSInode::add_child(InodeIdentifier child_id, const String& name, mode_t)
KResult ProcFSInode::add_child(InodeIdentifier child_id, const StringView& name, mode_t)
{
(void)child_id;
(void)name;
return KResult(-EPERM);
}
KResult ProcFSInode::remove_child(const String& name)
KResult ProcFSInode::remove_child(const StringView& name)
{
(void)name;
return KResult(-EPERM);

4
Kernel/FileSystem/ProcFS.h
View file

@ -86,8 +86,8 @@ private:
virtual InodeIdentifier lookup(StringView name) override;
virtual void flush_metadata() override;
virtual ssize_t write_bytes(off_t, ssize_t, const byte* buffer, FileDescription*) override;
virtual KResult add_child(InodeIdentifier child_id, const String& name, mode_t) override;
virtual KResult remove_child(const String& name) override;
virtual KResult add_child(InodeIdentifier child_id, const StringView& name, mode_t) override;
virtual KResult remove_child(const StringView& name) override;
virtual size_t directory_entry_count() const override;
virtual KResult chmod(mode_t) override;
virtual KResult chown(uid_t, gid_t) override;

4
Kernel/FileSystem/SyntheticFileSystem.cpp
View file

@ -262,14 +262,14 @@ ssize_t SynthFSInode::write_bytes(off_t offset, ssize_t size, const byte* buffer
return 0;
}
KResult SynthFSInode::add_child(InodeIdentifier child_id, const String& name, mode_t)
KResult SynthFSInode::add_child(InodeIdentifier child_id, const StringView& name, mode_t)
{
(void)child_id;
(void)name;
ASSERT_NOT_REACHED();
}
KResult SynthFSInode::remove_child(const String& name)
KResult SynthFSInode::remove_child(const StringView& name)
{
(void)name;
ASSERT_NOT_REACHED();

4
Kernel/FileSystem/SyntheticFileSystem.h
View file

@ -63,8 +63,8 @@ private:
virtual InodeIdentifier lookup(StringView name) override;
virtual void flush_metadata() override;
virtual ssize_t write_bytes(off_t, ssize_t, const byte* buffer, FileDescription*) override;
virtual KResult add_child(InodeIdentifier child_id, const String& name, mode_t) override;
virtual KResult remove_child(const String& name) override;
virtual KResult add_child(InodeIdentifier child_id, const StringView& name, mode_t) override;
virtual KResult remove_child(const StringView& name) override;
virtual size_t directory_entry_count() const override;
virtual KResult chmod(mode_t) override;
virtual KResult chown(uid_t, gid_t) override;