RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 19:37:35 +00:00
Code Issues Activity Actions

LibCore+Everywhere: Return ErrorOr from ConfigFile factory methods

Browse source 
I've attempted to handle the errors gracefully where it was clear how to
do so, and simple, but a lot of this was just adding
`release_value_but_fixme_should_propagate_errors()` in places.
This commit is contained in:
Sam Atkins 2022-02-06 13:33:42 +00:00 • committed by Tim Flynn
parent 1a4dd47d5f
commit 8260135d4d
31 changed files with 77 additions and 51 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/DevTools/HackStudio/ProjectTemplate.cpp
View file

@ -30,7 +30,10 @@ ProjectTemplate::ProjectTemplate(const String& id, const String& name, const Str
RefPtr<ProjectTemplate> ProjectTemplate::load_from_manifest(const String& manifest_path)
{
auto config = Core::ConfigFile::open(manifest_path);
auto maybe_config = Core::ConfigFile::open(manifest_path);
if (maybe_config.is_error())
return {};
auto config = maybe_config.release_value();
if (!config->has_group("HackStudioTemplate")
|| !config->has_key("HackStudioTemplate", "Name")