From 82696078b027c78f480698cfa4f73a2de5052222 Mon Sep 17 00:00:00 2001
From: pkotzbach <pawelkotzbach@gmail.com>
Date: Tue, 15 Sep 2020 19:37:36 +0200
Subject: [PATCH] LibGUI: Fix to ComboBox fields activation

---
 Libraries/LibGUI/ComboBox.cpp | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/Libraries/LibGUI/ComboBox.cpp b/Libraries/LibGUI/ComboBox.cpp
index a4e722b789..089fb560b1 100644
--- a/Libraries/LibGUI/ComboBox.cpp
+++ b/Libraries/LibGUI/ComboBox.cpp
@@ -60,10 +60,6 @@ ComboBox::ComboBox()
 {
     m_editor = add<ComboBoxEditor>();
     m_editor->set_has_open_button(true);
-    m_editor->on_change = [this] {
-        if (on_change)
-            on_change(m_editor->text(), m_list_view->cursor_index());
-    };
     m_editor->on_return_pressed = [this] {
         if (on_return_pressed)
             on_return_pressed();
@@ -121,15 +117,17 @@ ComboBox::ComboBox()
         m_editor->set_text(new_value);
         if (!m_only_allow_values_from_model)
             m_editor->select_all();
+    };
+
+    m_list_view->on_activation = [this](auto& index) {
         deferred_invoke([this, index](auto&) {
             if (on_change)
                 on_change(m_editor->text(), index);
         });
-    };
-    m_list_view->on_activation = [this](auto&) {
         m_list_view->set_activates_on_selection(false);
         close();
     };
+    
     m_list_view->on_escape_pressed = [this] {
         close();
     };