RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 21:42:43 +00:00
Code Issues Activity Actions

LibHTML: Implement basic support for "text-decoration: underline"

Browse source
This commit is contained in:
Andreas Kling 2019-09-28 22:31:41 +02:00
parent 62cbaa74f3
commit 8271ad40a5
2 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibHTML/CSS/StyleResolver.cpp
View file

@ -63,7 +63,7 @@ StyleProperties StyleResolver::resolve_style(const Element& element, const Style
if (parent_properties) { if (parent_properties) {
parent_properties->for_each_property([&](const StringView& name, auto& value) { parent_properties->for_each_property([&](const StringView& name, auto& value) {
// TODO: proper inheritance // TODO: proper inheritance
if (name.starts_with("font") || name == "white-space" || name == "color") if (name.starts_with("font") || name == "white-space" || name == "color" || name == "text-decoration")
style_properties.set_property(name, value); style_properties.set_property(name, value);
}); });
} }

6
Libraries/LibHTML/Layout/LayoutText.cpp
View file

@ -228,6 +228,9 @@ void LayoutText::render(RenderingContext& context)
painter.set_font(*m_font); painter.set_font(*m_font);
auto color = style_properties().color_or_fallback("color", Color::Black); auto color = style_properties().color_or_fallback("color", Color::Black);
auto text_decoration = style_properties().string_or_fallback("text-decoration", "none");
bool is_underline = text_decoration == "underline";
for (auto& run : m_runs) { for (auto& run : m_runs) {
Rect rect { Rect rect {
@ -237,5 +240,8 @@ void LayoutText::render(RenderingContext& context)
m_font->glyph_height() m_font->glyph_height()
}; };
painter.draw_text(rect, run.text, TextAlignment::TopLeft, color); painter.draw_text(rect, run.text, TextAlignment::TopLeft, color);
if (is_underline)
painter.draw_line(rect.bottom_left().translated(0, 1), rect.bottom_right().translated(0, 1), color);
} }
} }