RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 20:22:45 +00:00
Code Issues Activity Actions

Kernel: Stop using the make<T> factory method in the Kernel

Browse source 
As make<T> is infallible, it really should not be used anywhere in the
Kernel. Instead replace with fallible `new (nothrow)` calls, that will
eventually be error-propagated.
This commit is contained in:
Idan Horowitz 2022-02-03 16:33:46 +02:00 • committed by Andreas Kling
parent e5e7cb822a
commit 8289727fac
6 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Kernel/Storage/Partition/EBRPartitionTable.cpp
View file

@ -11,7 +11,7 @@ namespace Kernel {
Result<NonnullOwnPtr<EBRPartitionTable>, PartitionTable::Error> EBRPartitionTable::try_to_initialize(const StorageDevice& device)
{
auto table = make<EBRPartitionTable>(device);
auto table = adopt_nonnull_own_or_enomem(new (nothrow) EBRPartitionTable(device)).release_value_but_fixme_should_propagate_errors();
if (table->is_protective_mbr())
return { PartitionTable::Error::MBRProtective };
if (!table->is_valid())