RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 03:37:34 +00:00
Code Issues Activity Actions

LibCore: Rename File::ShouldCloseFile{Description => Descriptor}

Browse source 
From https://youtu.be/YNSAZIW3EM0?t=1474:

"Hmm... I don't think that name is right! From the perspective of
userspace, this is a file descriptor. File description is what the
kernel internally keeps track of, but as far as userspace is concerned,
he just has a file descriptor. [...] Maybe that name should be changed."

Core::File even has a member of this enum type... called
m_should_close_file_descriptor - so let's just rename it :^)
This commit is contained in:
Linus Groh 2020-10-25 11:31:27 +00:00 • committed by Andreas Kling
parent 664794b19e
commit 82956a08b3
9 changed files with 16 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibCore/File.h
View file

@ -52,11 +52,11 @@ public:
virtual bool open(IODevice::OpenMode) override;
enum class ShouldCloseFileDescription {
enum class ShouldCloseFileDescriptor {
No = 0,
Yes
};
bool open(int fd, IODevice::OpenMode, ShouldCloseFileDescription);
bool open(int fd, IODevice::OpenMode, ShouldCloseFileDescriptor);
static NonnullRefPtr<File> stdin();
static NonnullRefPtr<File> stdout();
@ -72,7 +72,7 @@ private:
bool open_impl(IODevice::OpenMode, mode_t);
String m_filename;
ShouldCloseFileDescription m_should_close_file_descriptor { ShouldCloseFileDescription::Yes };
ShouldCloseFileDescriptor m_should_close_file_descriptor { ShouldCloseFileDescriptor::Yes };
};
}