From 82b017181235d8baca940e2e7770572ae6e2209f Mon Sep 17 00:00:00 2001 From: Liav A Date: Sat, 19 Sep 2020 14:11:15 +0300 Subject: [PATCH] Kernel: Fix assertion statement in GenericInterruptHandler We need to assert if interrupts are not disabled when changing the interrupt number of an interrupt handler. Before this fix, any change like this would lead to a crash, because we are using InterruptDisabler in IRQHandler::change_irq_number. --- Kernel/Interrupts/GenericInterruptHandler.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Kernel/Interrupts/GenericInterruptHandler.cpp b/Kernel/Interrupts/GenericInterruptHandler.cpp index 2101c705e8..609fb5e906 100644 --- a/Kernel/Interrupts/GenericInterruptHandler.cpp +++ b/Kernel/Interrupts/GenericInterruptHandler.cpp @@ -56,7 +56,7 @@ GenericInterruptHandler::~GenericInterruptHandler() void GenericInterruptHandler::change_interrupt_number(u8 number) { - ASSERT_INTERRUPTS_ENABLED(); + ASSERT_INTERRUPTS_DISABLED(); ASSERT(!m_disable_remap); unregister_generic_interrupt_handler(InterruptManagement::acquire_mapped_interrupt_number(interrupt_number()), *this); m_interrupt_number = number;