RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 13:57:35 +00:00
Code Issues Activity Actions

LibWeb: Tidy up and add spec comments to FFC layout algorithm step 3

Browse source
This commit is contained in:
Andreas Kling 2021-10-13 23:26:31 +02:00
parent 1e832dd91a
commit 82bb5ef8b7
1 changed files with 58 additions and 41 deletions
Download patch file Download diff file Expand all files Collapse all files

99
Userland/Libraries/LibWeb/Layout/FlexFormattingContext.cpp
View file

@ -447,50 +447,67 @@ float FlexFormattingContext::layout_for_maximum_main_size(Box& box)
void FlexFormattingContext::determine_flex_base_size_and_hypothetical_main_size(FlexItem& flex_item) void FlexFormattingContext::determine_flex_base_size_and_hypothetical_main_size(FlexItem& flex_item)
{ {
auto& child_box = flex_item.box; auto& child_box = flex_item.box;
auto const& flex_basis = child_box.computed_values().flex_basis();
if (flex_basis.type == CSS::FlexBasis::Length) { flex_item.flex_base_size = [&] {
// A auto const& used_flex_basis = child_box.computed_values().flex_basis();
auto specified_base_size = get_pixel_size(child_box, flex_basis.length);
if (specified_base_size == 0) // A. If the item has a definite used flex basis, that’s the flex base size.
flex_item.flex_base_size = calculated_main_size(flex_item.box); if (used_flex_basis.is_definite()) {
else auto specified_base_size = get_pixel_size(child_box, used_flex_basis.length);
flex_item.flex_base_size = specified_base_size; if (specified_base_size == 0)
} else if (flex_basis.type == CSS::FlexBasis::Content return calculated_main_size(flex_item.box);
&& has_definite_cross_size(child_box) return specified_base_size;
// FIXME: && has intrinsic aspect ratio. }
&& false) {
// B // B. If the flex item has ...
TODO(); // - an intrinsic aspect ratio,
// flex_base_size is calculated from definite cross size and intrinsic aspect ratio // - a used flex basis of content, and
} else if (flex_basis.type == CSS::FlexBasis::Content // - a definite cross size,
// FIXME: && sized under min-content or max-content contstraints bool has_intrinsic_aspect_ratio = false; // FIXME: Populate this.
&& false) { if (has_intrinsic_aspect_ratio
// C && used_flex_basis.type == CSS::FlexBasis::Content
TODO(); && has_definite_cross_size(child_box)) {
// Size child_box under the constraints, flex_base_size is then the resulting main_size. TODO();
} else if (flex_basis.type == CSS::FlexBasis::Content // flex_base_size is calculated from definite cross size and intrinsic aspect ratio
// FIXME: && main_size is infinite && inline axis is parallel to the main axis }
&& false && false) {
// D // C. If the used flex basis is content or depends on its available space,
TODO(); // and the flex container is being sized under a min-content or max-content constraint
// Use rules for a flex_container in orthogonal flow // (e.g. when performing automatic table layout [CSS21]), size the item under that constraint.
} else { // The flex base size is the item’s resulting main size.
// E if (used_flex_basis.type == CSS::FlexBasis::Content
// FIXME: && sized under min-content or max-content constraints
&& false) {
TODO();
// Size child_box under the constraints, flex_base_size is then the resulting main_size.
}
// D. Otherwise, if the used flex basis is content or depends on its available space,
// the available main size is infinite, and the flex item’s inline axis is parallel to the main axis,
// lay the item out using the rules for a box in an orthogonal flow [CSS3-WRITING-MODES].
// The flex base size is the item’s max-content main size.
if (used_flex_basis.type == CSS::FlexBasis::Content
// FIXME: && main_size is infinite && inline axis is parallel to the main axis
&& false && false) {
TODO();
// Use rules for a flex_container in orthogonal flow
}
// E. Otherwise, size the item into the available space using its used flex basis in place of its main size,
// treating a value of content as max-content. If a cross size is needed to determine the main size
// (e.g. when the flex item’s main size is in its block axis) and the flex item’s cross size is auto and not definite,
// in this calculation use fit-content as the flex item’s cross size.
// The flex base size is the item’s resulting main size.
// FIXME: This is probably too naive. // FIXME: This is probably too naive.
// FIXME: Care about FlexBasis::Auto // FIXME: Care about FlexBasis::Auto
if (has_definite_main_size(child_box)) { if (has_definite_main_size(child_box))
flex_item.flex_base_size = specified_main_size_of_child_box(child_box); return specified_main_size_of_child_box(child_box);
} else { return layout_for_maximum_main_size(child_box);
flex_item.flex_base_size = layout_for_maximum_main_size(child_box); }();
}
}
auto clamp_min = has_main_min_size(child_box)
? specified_main_min_size(child_box)
: 0;
auto clamp_max = has_main_max_size(child_box)
? specified_main_max_size(child_box)
: NumericLimits<float>::max();
// The hypothetical main size is the item’s flex base size clamped according to its used min and max main sizes (and flooring the content box size at zero).
auto clamp_min = has_main_min_size(child_box) ? specified_main_min_size(child_box) : 0;
auto clamp_max = has_main_max_size(child_box) ? specified_main_max_size(child_box) : NumericLimits<float>::max();
flex_item.hypothetical_main_size = clamp(flex_item.flex_base_size, clamp_min, clamp_max); flex_item.hypothetical_main_size = clamp(flex_item.flex_base_size, clamp_min, clamp_max);
} }