RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-06-01 06:18:12 +00:00
Code Issues Activity Actions

LibJS/JIT: Handle uninitialized bindings in GetLocal

Browse source 
test262: +78 ✅    -72 ❌    -4 💥️
This commit is contained in:
Simon Wanner 2023-10-30 09:55:50 +01:00 • committed by Andreas Kling
parent 5b2c0dfec0
commit 82c057391e
1 changed files with 23 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

23
Userland/Libraries/LibJS/JIT/Compiler.cpp
View file

@ -93,9 +93,32 @@ void Compiler::compile_store(Bytecode::Op::Store const& op)
store_vm_register(op.dst(), GPR0);
}
static Value cxx_throw_binding_not_initialized(VM& vm, size_t index)
{
auto const& variable_name = vm.running_execution_context().function->local_variables_names()[index];
TRY_OR_SET_EXCEPTION(vm.throw_completion<ReferenceError>(ErrorType::BindingNotInitialized, variable_name));
return {};
}
void Compiler::compile_get_local(Bytecode::Op::GetLocal const& op)
{
load_vm_local(GPR0, op.index());
// if (GPR0 == <empty>) throw ReferenceError(BindingNotInitialized)
Assembler::Label not_empty {};
m_assembler.mov(
Assembler::Operand::Register(GPR1),
Assembler::Operand::Imm(Value().encoded()));
m_assembler.jump_if(
Assembler::Operand::Register(GPR0),
Assembler::Condition::NotEqualTo,
Assembler::Operand::Register(GPR1),
not_empty);
m_assembler.mov(Assembler::Operand::Register(ARG1), Assembler::Operand::Imm(op.index()));
native_call((void*)cxx_throw_binding_not_initialized);
check_exception();
not_empty.link(m_assembler);
store_vm_register(Bytecode::Register::accumulator(), GPR0);
}