From 82c36b303cc9c73048fb81124609f5f56b45fcf0 Mon Sep 17 00:00:00 2001 From: Matthew Olsson Date: Sat, 4 Nov 2023 13:09:17 -0700 Subject: [PATCH] IDLGenerators: Do not emit null literals as default values --- .../CodeGenerators/LibWeb/BindingsGenerator/IDLGenerators.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Meta/Lagom/Tools/CodeGenerators/LibWeb/BindingsGenerator/IDLGenerators.cpp b/Meta/Lagom/Tools/CodeGenerators/LibWeb/BindingsGenerator/IDLGenerators.cpp index 0c1cd8e087..6460787733 100644 --- a/Meta/Lagom/Tools/CodeGenerators/LibWeb/BindingsGenerator/IDLGenerators.cpp +++ b/Meta/Lagom/Tools/CodeGenerators/LibWeb/BindingsGenerator/IDLGenerators.cpp @@ -439,7 +439,7 @@ static void generate_to_cpp(SourceGenerator& generator, ParameterType& parameter @parameter.type.name@ @cpp_name@ = TRY(@js_name@@js_suffix@.to_double(vm)); )~~~"); } else { - if (optional_default_value.has_value()) { + if (optional_default_value.has_value() && optional_default_value != "null"sv) { scoped_generator.append(R"~~~( @parameter.type.name@ @cpp_name@; )~~~"); @@ -452,7 +452,7 @@ static void generate_to_cpp(SourceGenerator& generator, ParameterType& parameter if (!@js_name@@js_suffix@.is_undefined()) @cpp_name@ = TRY(@js_name@@js_suffix@.to_double(vm)); )~~~"); - if (optional_default_value.has_value()) { + if (optional_default_value.has_value() && optional_default_value.value() != "null"sv) { scoped_generator.append(R"~~~( else @cpp_name@ = @parameter.optional_default_value@;