RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 20:57:35 +00:00
Code Issues Activity Actions

LibGUI: Actually update the selection in ComboBox::set_selected_index

Browse source 
Previously we would not set m_selected_index or the editor's text value
when calling set_selected_index.
This commit is contained in:
networkException 2022-06-16 21:52:08 +02:00 • committed by Linus Groh
parent 695dfabc2e
commit 82f537b847
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibGUI/ComboBox.cpp
View file

@ -213,7 +213,9 @@ void ComboBox::set_selected_index(size_t index, AllowCallback allow_callback)
return;
size_t previous_index = selected_index();
TemporaryChange change(m_updating_model, true);
m_list_view->set_cursor(m_list_view->model()->index(index, 0), AbstractView::SelectionUpdate::Set);
auto model_index = m_list_view->model()->index(index, 0);
m_list_view->set_cursor(model_index, AbstractView::SelectionUpdate::Set);
selection_updated(model_index);
if (previous_index != selected_index() && on_change && allow_callback == AllowCallback::Yes)
on_change(m_editor->text(), m_list_view->cursor_index());
}