RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 13:47:45 +00:00
Code Issues Activity Actions

LibHTML: Fix broken parsing of ID and class selectors

Browse source 
We were forgetting to consume the '#' and '.' characters.
This commit is contained in:
Andreas Kling 2019-09-29 17:26:05 +02:00
parent ed39e0f6f7
commit 830e18e486
1 changed files with 8 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Libraries/LibHTML/Parser/CSSParser.cpp
View file

@ -86,12 +86,16 @@ NonnullRefPtr<StyleSheet> parse_css(const String& css)
auto parse_selector = [&] { auto parse_selector = [&] {
consume_whitespace(); consume_whitespace();
Selector::Component::Type type; Selector::Component::Type type;
if (peek() == '.')
if (peek() == '.') {
type = Selector::Component::Type::Class; type = Selector::Component::Type::Class;
else if (peek() == '#') consume_one();
} else if (peek() == '#') {
type = Selector::Component::Type::Id; type = Selector::Component::Type::Id;
else consume_one();
} else {
type = Selector::Component::Type::TagName; type = Selector::Component::Type::TagName;
}
while (is_valid_selector_char(peek())) while (is_valid_selector_char(peek()))
buffer.append(consume_one()); buffer.append(consume_one());
@ -160,6 +164,7 @@ NonnullRefPtr<StyleSheet> parse_css(const String& css)
parse_declarations(); parse_declarations();
consume_specific('}'); consume_specific('}');
rules.append(StyleRule::create(move(current_rule.selectors), move(current_rule.declarations))); rules.append(StyleRule::create(move(current_rule.selectors), move(current_rule.declarations)));
consume_whitespace();
}; };
while (index < css.length()) { while (index < css.length()) {