RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 17:12:43 +00:00
Code Issues Activity Actions

LibGUI: Only consider starting a drag from an already selected item

Browse source 
This means we can deselect other items immediately when performing a mouse-down
on an unselected item.
This commit is contained in:
Sergey Bugaev 2020-01-28 16:25:46 +03:00 • committed by Andreas Kling
parent f9b4d981a8
commit 831ff2d0ac
1 changed files with 1 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Libraries/LibGUI/GAbstractView.cpp
View file

@ -191,10 +191,9 @@ void GAbstractView::mousedown_event(GMouseEvent& event)
m_selection.clear(); m_selection.clear();
} else if (event.modifiers() & Mod_Ctrl) { } else if (event.modifiers() & Mod_Ctrl) {
m_selection.toggle(index); m_selection.toggle(index);
} else if (event.button() == GMouseButton::Left && !m_model->drag_data_type().is_null()) { } else if (event.button() == GMouseButton::Left && m_selection.contains(index) && !m_model->drag_data_type().is_null()) {
// We might be starting a drag, so don't throw away other selected items yet. // We might be starting a drag, so don't throw away other selected items yet.
m_might_drag = true; m_might_drag = true;
m_selection.add(index);
} else { } else {
m_selection.set(index); m_selection.set(index);
} }