RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-03 00:52:12 +00:00
Code Issues Activity Actions

AK+LibHTTP: Revert prior change to percent encode plus signs

Browse source 
A change was made prior to percent encode plus signs in order to fix an
issue with the Google cookie consent page.

Unforunately, this was treating a symptom of a problem and not the root
cause and is incorrect behavior.
This commit is contained in:
GeekFiftyFive 2022-04-08 14:20:30 +01:00 • committed by Andreas Kling
parent a2d89f11d1
commit 832920c003
3 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibHTTP/HttpRequest.cpp
View file

@ -37,7 +37,7 @@ ByteBuffer HttpRequest::to_raw_request() const
builder.append(URL::percent_encode(m_url.path(), URL::PercentEncodeSet::EncodeURI));
if (!m_url.query().is_empty()) {
builder.append('?');
builder.append(URL::percent_encode(m_url.query(), URL::PercentEncodeSet::EncodeURI, "+"sv));
builder.append(URL::percent_encode(m_url.query(), URL::PercentEncodeSet::EncodeURI));
}
builder.append(" HTTP/1.1\r\nHost: ");
builder.append(m_url.host());